Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Announcement is not reflecting the latest announcement #2477

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

japhethLG
Copy link
Contributor

@japhethLG japhethLG commented Aug 2, 2024

Description

Add a sort logic for product announcements. Remove "Good Night" when the user logs in at night.

Fixes #2476 #250

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual Test

Screenshots / Screen recording

Please add screenshots or recording if applicable
Before:
image

After:
image

@japhethLG japhethLG requested a review from darwin808 August 2, 2024 18:10
@darwin808 darwin808 merged commit a95eaa5 into stage Aug 5, 2024
10 checks passed
@darwin808 darwin808 deleted the fix/login-page branch August 5, 2024 01:55
japhethLG added a commit that referenced this pull request Nov 22, 2024
# Description

Add a sort logic for product announcements. Remove "Good Night" when the
user logs in at night.

Fixes #2476 [#250](zesty-io/accounts-ui#250)
## Type of change

Please delete options that are not relevant.

- [x] Bug fix (non-breaking change which fixes an issue)

# How Has This Been Tested?

- [x] Manual Test

# Screenshots / Screen recording

Please add screenshots or recording if applicable
Before:

![image](https://github.com/user-attachments/assets/ca977a94-786b-4219-9522-4ecddbbac870)

After:

![image](https://github.com/user-attachments/assets/a76aeac6-8961-4e56-9b16-bba34f2a968a)
japhethLG added a commit that referenced this pull request Nov 22, 2024
# Description

Add a sort logic for product announcements. Remove "Good Night" when the
user logs in at night.

Fixes #2476 [#250](zesty-io/accounts-ui#250)
## Type of change

Please delete options that are not relevant.

- [x] Bug fix (non-breaking change which fixes an issue)

# How Has This Been Tested?

- [x] Manual Test

# Screenshots / Screen recording

Please add screenshots or recording if applicable
Before:

![image](https://github.com/user-attachments/assets/ca977a94-786b-4219-9522-4ecddbbac870)

After:

![image](https://github.com/user-attachments/assets/a76aeac6-8961-4e56-9b16-bba34f2a968a)
giseleblair pushed a commit that referenced this pull request Nov 22, 2024
#2459 
#2468
#2470 
#2474 
#2477
#2488 
#2490
#2491

---------

Signed-off-by: Japheth Louie M. Gofredo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login Page: Announcement is not reflecting the latest announcement
2 participants