Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Page: Announcement is not reflecting the latest announcement #2476

Open
zcolah opened this issue Jul 29, 2024 · 2 comments · Fixed by #2477
Open

Login Page: Announcement is not reflecting the latest announcement #2476

zcolah opened this issue Jul 29, 2024 · 2 comments · Fixed by #2477
Assignees
Labels
bug Something isn't working

Comments

@zcolah
Copy link

zcolah commented Jul 29, 2024

Bug

The login page does not reflect the latest in app product announcement regarding the Summer Product Release. @agalin920 has shared that this is because the logic selects the first item from the response.

Solution

Read the response, filter to only the published items, and then identify the published item with the most recent start date, and display that item in the announcement area adjacent to the login buttons.

In Case of Overlaps
In situations where two or more announcements share the same start date, a priority system must be put in place to ensure consistent user experience. The announcement that was created most recently should take priority. The rationale behind this is to give precedence to the most current or updated promotions that the Zesty.io marketing team wishes to convey.

@zcolah zcolah converted this from a draft issue Jul 29, 2024
@zcolah zcolah added the bug Something isn't working label Jul 29, 2024
@japhethLG japhethLG self-assigned this Aug 2, 2024
@github-project-automation github-project-automation bot moved this from Design Ready to Recently Completed in Product Roadmap Aug 5, 2024
@zcolah
Copy link
Author

zcolah commented Aug 5, 2024

@japhethLG I checked the login page and noticed it is still not displaying the latest product announcement despite the following issue being labelled as fixed. May you please reopen the ticket, and before closing it again, make it go through VQA with me?

@japhethLG
Copy link
Contributor

@zcolah it's automatically closing after merging it to stage, it's still in stage atm https://zesty-website-m3rbwjxm5q-uc.a.run.app/login/ , will request a merge to prod once you approve.

@japhethLG japhethLG reopened this Aug 5, 2024
@github-project-automation github-project-automation bot moved this from Recently Completed to In Progress in Product Roadmap Aug 5, 2024
japhethLG added a commit that referenced this issue Nov 22, 2024
# Description

Add a sort logic for product announcements. Remove "Good Night" when the
user logs in at night.

Fixes #2476 [#250](zesty-io/accounts-ui#250)
## Type of change

Please delete options that are not relevant.

- [x] Bug fix (non-breaking change which fixes an issue)

# How Has This Been Tested?

- [x] Manual Test

# Screenshots / Screen recording

Please add screenshots or recording if applicable
Before:

![image](https://github.com/user-attachments/assets/ca977a94-786b-4219-9522-4ecddbbac870)

After:

![image](https://github.com/user-attachments/assets/a76aeac6-8961-4e56-9b16-bba34f2a968a)
japhethLG added a commit that referenced this issue Nov 22, 2024
# Description

Add a sort logic for product announcements. Remove "Good Night" when the
user logs in at night.

Fixes #2476 [#250](zesty-io/accounts-ui#250)
## Type of change

Please delete options that are not relevant.

- [x] Bug fix (non-breaking change which fixes an issue)

# How Has This Been Tested?

- [x] Manual Test

# Screenshots / Screen recording

Please add screenshots or recording if applicable
Before:

![image](https://github.com/user-attachments/assets/ca977a94-786b-4219-9522-4ecddbbac870)

After:

![image](https://github.com/user-attachments/assets/a76aeac6-8961-4e56-9b16-bba34f2a968a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Recently Completed
Development

Successfully merging a pull request may close this issue.

2 participants