-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login Page: Announcement is not reflecting the latest announcement #2476
Comments
@japhethLG I checked the login page and noticed it is still not displaying the latest product announcement despite the following issue being labelled as fixed. May you please reopen the ticket, and before closing it again, make it go through VQA with me? |
@zcolah it's automatically closing after merging it to stage, it's still in stage atm https://zesty-website-m3rbwjxm5q-uc.a.run.app/login/ , will request a merge to prod once you approve. |
# Description Add a sort logic for product announcements. Remove "Good Night" when the user logs in at night. Fixes #2476 [#250](zesty-io/accounts-ui#250) ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) # How Has This Been Tested? - [x] Manual Test # Screenshots / Screen recording Please add screenshots or recording if applicable Before: ![image](https://github.com/user-attachments/assets/ca977a94-786b-4219-9522-4ecddbbac870) After: ![image](https://github.com/user-attachments/assets/a76aeac6-8961-4e56-9b16-bba34f2a968a)
# Description Add a sort logic for product announcements. Remove "Good Night" when the user logs in at night. Fixes #2476 [#250](zesty-io/accounts-ui#250) ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) # How Has This Been Tested? - [x] Manual Test # Screenshots / Screen recording Please add screenshots or recording if applicable Before: ![image](https://github.com/user-attachments/assets/ca977a94-786b-4219-9522-4ecddbbac870) After: ![image](https://github.com/user-attachments/assets/a76aeac6-8961-4e56-9b16-bba34f2a968a)
Bug
The login page does not reflect the latest in app product announcement regarding the Summer Product Release. @agalin920 has shared that this is because the logic selects the first item from the response.
Solution
Read the response, filter to only the published items, and then identify the published item with the most recent start date, and display that item in the announcement area adjacent to the login buttons.
In Case of Overlaps
In situations where two or more announcements share the same start date, a priority system must be put in place to ensure consistent user experience. The announcement that was created most recently should take priority. The rationale behind this is to give precedence to the most current or updated promotions that the Zesty.io marketing team wishes to convey.
The text was updated successfully, but these errors were encountered: