Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Snack Bar Component: Added Icon & Variants #36

Open
zcolah opened this issue Aug 22, 2022 · 2 comments
Open

Update Snack Bar Component: Added Icon & Variants #36

zcolah opened this issue Aug 22, 2022 · 2 comments
Assignees

Comments

@zcolah
Copy link

zcolah commented Aug 22, 2022

The material design snack bar has no icons or variants. These do not follow the best practices established in the industry. Hence I have made 4 variants - default, success, warning, and danger that indicate to a user the type of action that has taken place. In addition this I have added an icon to the snack bar to act as a signifier.

You can see the updated Snackbar in Figma here: https://www.figma.com/file/vyCg0SdVZwBElSAQ6xjwNj/DISCO-%7C%7C-Design-System?node-id=9348%3A75132

@agalin920
Copy link
Contributor

agalin920 commented Aug 22, 2022

@zcolah Snackbar wraps Alerts https://mui.com/material-ui/react-alert/#main-content that do have variants called 'severity' https://mui.com/material-ui/react-snackbar/

These overrides should be on Alert components

@agalin920 agalin920 transferred this issue from zesty-io/manager-ui Aug 23, 2022
@zcolah
Copy link
Author

zcolah commented Aug 23, 2022

@agalin920 great catch. I have updated the alert filled colors to pass accessibility tests and will be using them henceforth for our snackbars. You can see the Figma for the same here: https://www.figma.com/file/vyCg0SdVZwBElSAQ6xjwNj/DISCO-%7C%7C-Design-System?node-id=6595%3A48211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants