Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: adc: Place API into iterable section #72292

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

pdgendt
Copy link
Collaborator

@pdgendt pdgendt commented May 3, 2024

Move all adc driver api structs into an iterable section.

Depends on #71773

Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jul 13, 2024
@pdgendt pdgendt removed the Stale label Jul 13, 2024
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Sep 12, 2024
@pdgendt pdgendt removed the Stale label Sep 12, 2024
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

Do not update the ref_internal value in the API structure.

Signed-off-by: Pieter De Gendt <[email protected]>
Move all adc driver api structs into an iterable section, this allows us
to verify if an api pointer is located in compatible linker section.

Signed-off-by: Pieter De Gendt <[email protected]>
Add a test case where CONFIG_CMAKE_LINKER_GENERATOR is enabled.

Signed-off-by: Pieter De Gendt <[email protected]>
Add a migration entry for the device driver API change, and start listing
driver classes that have been updated in-tree.

Signed-off-by: Pieter De Gendt <[email protected]>
The :c:macro:`DEVICE_API()` macro should be used by out-of-tree driver implementations for
the following driver classes:

* :c:struct:`adc_driver_api`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to do this in a separate PR for all modified driver classes after the corresponding PRs are merged?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going to do it in a follow-up to add the other entries.

@pdgendt pdgendt added the area: ADC Analog-to-Digital Converter (ADC) label Nov 29, 2024
@kartben kartben merged commit 5a78f8f into zephyrproject-rtos:main Nov 29, 2024
26 checks passed
@pdgendt pdgendt deleted the linker-api-adc branch November 29, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ADC Analog-to-Digital Converter (ADC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants