posix: abstract pthread_cond_t as uint32_t #52173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
requested review from
keith-packard,
enjiamai,
stephanosio,
jeremybettis and
KangJianX
|
Compliance check failures are a false positive (pthread functions return non-negative errno values) |
cfriedt
force-pushed
the
use-uint32-for-pthread-cond
branch
from
0133f71
to
ce8984d
Compare
jeremybettis
previously approved these changes
Nov 14, 2022
cfriedt
force-pushed
the
use-uint32-for-pthread-cond
branch
2 times, most recently
from
cbc89eb
to
bf563a6
Compare
jeremybettis
previously approved these changes
Nov 15, 2022
|
@stephanosio - are you able to take a look? |
stephanosio
previously requested changes
Nov 16, 2022
lib/posix/pthread_cond.c
Outdated
| return cv - posix_cond_pool; | ||
| } | ||
|
|
||
| static inline size_t to_posix_cond_idx(pthread_mutex_t cond) |
lib/posix/posix_internal.h
Outdated
Comment on lines
14
to
15
| #define PTHREAD_MUTEX_MASK_INIT 0x80000000 | ||
| #define PTHREAD_COND_MASK_INIT PTHREAD_MUTEX_MASK_INIT |
There was a problem hiding this comment.
Does it really make sense to define PTHREAD_COND_MASK_INIT in terms of PTHREAD_MUTEX_MASK_INIT? I understand that they have the same value, but defining it as such does not seem very logical.
Maybe it would be better to introduce something like #define PTHREAD_OBJ_INIT_MASK 0x80000000 and define both PTHREAD_MUTEX_MASK_INIT and PTHREAD_COND_MASK_INIT in terms of that?
Previously `PTHREAD_MUTEX_MASK_INIT` was used to mark a `pthread_mutex_t` as initialized. The same needs to be done for `pthread_cond_t` and likely others. Rather than copy-pasting that and a number of inlines that duplicate the same functionality, simply make it more generic. Signed-off-by: Chris Friedt <[email protected]>
Previously, `pthread_cond_init()` could not actually fail, and destroying condition variables was a no-op, and it was missing in `pthread_exit()`. However, with the change of `pthread_cond_t` to `uint32_t`, and since those are embedded inside of `struct posix_thread` for the time being, the pthread code needs to keep track that it is relinquishes used condition variables when a thread completes. Signed-off-by: Chris Friedt <[email protected]>
Consistent with the change of `pthread_t` from `struct posix_thread` to `uint32_t`, we can now also abstract `pthread_cond_t` as `uint32_t` and separate `struct posix_cond` as an implementation detail, hidden from POSIX API consumers. This change deprecates `PTHREAD_COND_DEFINE()` in favour of the (standardized) `PTHREAD_COND_INITIALIZER`. This change introduces `CONFIG_MAX_PTHREAD_COND_COUNT`. Signed-off-by: Chris Friedt <[email protected]>
Add a test to ensure that `pthread_cond_t` can be used over and over again and that there is no resource leakage with proper usage. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
use-uint32-for-pthread-cond
branch
from
bf563a6
to
f622477
Compare
|
@stephanosio, @jeremybettis - should be ready for round 2, if you have a moment. |
This was referenced Nov 16, 2022
stephanosio
approved these changes
Nov 17, 2022
|
@enjiamai @KangJianX - any reviews from you? |
|
@jeremybettis - IIRC you had previously approved this one. Will you re-ack? |
|
@keith-packard would you maybe ack? This is blocking a few PRs still.. |
mbolivar-nordic
approved these changes
Nov 18, 2022
jeremybettis
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4 commits
See individual commit messages for details.