Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper API: Rename motion control related functions #81789

Open
1 task
jilaypandya opened this issue Nov 22, 2024 · 1 comment
Open
1 task

Stepper API: Rename motion control related functions #81789

jilaypandya opened this issue Nov 22, 2024 · 1 comment
Assignees
Labels
area: Stepper Enhancement Changes/Updates/Additions to existing features RFC Request For Comments: want input from the community

Comments

@jilaypandya
Copy link
Contributor

jilaypandya commented Nov 22, 2024

Introduction

Problem description

Stepper API in current state comprises of following functions for motion control:

  1. stepper_move for triggering relative motion.
  2. stepper_set_target_position for triggering absolute position from reference position.
  3. stepper_set_actual_position for setting reference position.
  4. stepper_enable_constant_velocity_mode for triggering continuous motion in a given direction with a given velocity.

Proposed change

These function names could become more intuitive if renamed as following:

  1. stepper_move -> stepper_move_by for the number of relative steps to move.
  2. stepper_set_target_position -> stepper_move_to for the absolute position to be reached.
  3. stepper_set_actual_position -> stepper_set_reference_position for the the reference position from which the steps are to be counted.
  4. stepper_enable_constant_velocity_mode -> stepper_run for the brevity of the actual function.

Detailed RFC

Proposed change (Detailed)

Following files will have to be refactored:

API:

  • stepper_api
  • move_to, move_by and run shall be non-blocking operations

Drivers:

Docs:

Tests:

Entry in migration guide:

Dependencies

None

Concerns and Unresolved Questions

Alternatives

Tasks

  1. Enhancement RFC Release Notes area: Stepper
    fabiobaltieri kartben
@jilaypandya jilaypandya added the RFC Request For Comments: want input from the community label Nov 22, 2024
@jilaypandya jilaypandya moved this to Review in RFC Backlog Nov 22, 2024
@jilaypandya jilaypandya self-assigned this Nov 22, 2024
@jilaypandya jilaypandya added area: Stepper Enhancement Changes/Updates/Additions to existing features labels Nov 22, 2024
@rruuaanng
Copy link
Collaborator

I think it's great and I like the new names, but I don't know what other people think of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Stepper Enhancement Changes/Updates/Additions to existing features RFC Request For Comments: want input from the community
Projects
Status: Review
Development

No branches or pull requests

2 participants