Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: ISO: Remove CONFIG_BT_ISO_TX_MTU #81722

Open
Thalley opened this issue Nov 21, 2024 · 2 comments
Open

Bluetooth: ISO: Remove CONFIG_BT_ISO_TX_MTU #81722

Thalley opened this issue Nov 21, 2024 · 2 comments
Assignees
Labels
area: Bluetooth ISO Bluetooth LE Isochronous Channels area: Bluetooth Enhancement Changes/Updates/Additions to existing features

Comments

@Thalley
Copy link
Collaborator

Thalley commented Nov 21, 2024

Is your enhancement proposal related to a problem? Please describe.
CONFIG_BT_ISO_TX_MTU today is not used by the host.

It has 3 uses

  1. Many samples and tests are using this value to define their TX buffer pools
  2. hci_raw.c uses it to define the size of the hci_iso_pool.
  3. The controller optionally uses it to determine the HCI ISO TX buffer size, but CONFIG_BT_CTLR_ISO_TX_BUFFER_SIZE can be directly for that too

Describe the solution you'd like
Remove the Kconfig as the host doesn't it and the applications shouldn't. For hci_raw and the HCI ISO tx buffer sizes we can/should use CONFIG_BT_CTLR_ISO_TX_BUFFER_SIZE.

Describe alternatives you've considered
N/A

Additional context
N/A

@Thalley Thalley added Enhancement Changes/Updates/Additions to existing features area: Bluetooth area: Bluetooth ISO Bluetooth LE Isochronous Channels labels Nov 21, 2024
@Thalley Thalley self-assigned this Nov 21, 2024
@kruithofa
Copy link
Collaborator

Before doing this we need to add a babblesim test with HCI packets larger than the HCI MTU size, basically testing fragmented HCI packets

@Thalley
Copy link
Collaborator Author

Thalley commented Nov 26, 2024

PR adding the fragmented test: #81871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth ISO Bluetooth LE Isochronous Channels area: Bluetooth Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

No branches or pull requests

2 participants