Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples without sample.yaml #27813

Closed
2 tasks
pabigot opened this issue Aug 26, 2020 · 4 comments · Fixed by #27913
Closed
2 tasks

samples without sample.yaml #27813

pabigot opened this issue Aug 26, 2020 · 4 comments · Fixed by #27913
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@pabigot
Copy link
Collaborator

pabigot commented Aug 26, 2020

Parallel to #27805 these are samples that lack a sample.yaml so may not be participating in CI as expected.

  • samples/boards/intel_s1000_crb/dmic
  • samples/subsys/mgmt/osdp

* [ ] samples/testing/integration (has a testcase.yaml instead) apparently this is not a sample

@pabigot pabigot added the bug The issue is a bug, or the PR is fixing a bug label Aug 26, 2020
@jenmwms
Copy link
Collaborator

jenmwms commented Sep 1, 2020

From what I understand, the first on this list (samples/application_development/out_of_tree_driver/hello_world_module/zephyr) is satisfied by samples/application_development/out_of_tree_driver/sample.yaml

@jenmwms
Copy link
Collaborator

jenmwms commented Sep 1, 2020

For this one: samples/testing/integration
From what I can tell, this should remain as testcase.yaml (no change needed) based on the accompanying description in doc/guides/test/ztest.rst

@MaureenHelm MaureenHelm added the priority: low Low impact/importance bug label Sep 1, 2020
@jenmwms
Copy link
Collaborator

jenmwms commented Sep 1, 2020

For the last two: samples/subsys/ipc/.../remote
My understanding is these do not need a sample.yaml here in the structure. The inclusion of /remote occurs in samples/subsys/ipc/ipm_mcux/CMakeLists.txt and samples/subsys/ipc/openamp/CMakeLists.txt. For example:

include(ExternalProject)

ExternalProject_Add(
  openamp_remote
  SOURCE_DIR ${APPLICATION_SOURCE_DIR}/remote

So, only 2 of the 6 identified need a sample.yaml:

  • samples/boards/intel_s1000_crb/dmic
  • samples/subsys/mgmt/osdp

Please see the PR #27913

@jenmwms jenmwms added the has-pr label Sep 1, 2020
@pabigot
Copy link
Collaborator Author

pabigot commented Sep 2, 2020

Thanks, I removed the ipc ones, and the out-of-tree where the sample.yaml is a couple directories up.

It's confusing that we have a test in the samples directory (where it probably isn't being executed), or maybe it's a non-executable sample ("example" would be better). I'll just document it above and let it go....

jenmwms added a commit to jenmwms/zephyr that referenced this issue Sep 2, 2020
Some samples were without sample.yaml. This adds
them.

Fixes zephyrproject-rtos#27813

Signed-off-by: Jennifer Williams <[email protected]>
nashif pushed a commit that referenced this issue Sep 3, 2020
Some samples were without sample.yaml. This adds
them.

Fixes #27813

Signed-off-by: Jennifer Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants