From a65b8d40fbf4d7aa1e5cc1f2f6bd85a4a0706238 Mon Sep 17 00:00:00 2001 From: Marc Herbert Date: Mon, 11 Dec 2023 01:26:58 +0000 Subject: [PATCH] west: sign.py: always log the rimage command rimage is very verbose by default and has no -q(uiet) option, so saving one line out of more than 100 lines is pointless. RimageSigner.sign() was already very complex and suffering from combinatorial explosion of parameters. With .toml pre-processing (#65411) it's getting worse, so we really need all build logs to show the complete rimage command. Signed-off-by: Marc Herbert --- scripts/west_commands/sign.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/west_commands/sign.py b/scripts/west_commands/sign.py index cd29dd589cf34e..4e5e459eff5fc1 100644 --- a/scripts/west_commands/sign.py +++ b/scripts/west_commands/sign.py @@ -535,7 +535,8 @@ def sign(self, command, build_dir, build_conf, formats): sign_base = [tool_path] - # Sub-command arg '-q' takes precedence over west '-v' + # Align rimage verbosity. + # Sub-command arg 'west sign -q' takes precedence over west '-v' if not args.quiet and args.verbose: sign_base += ['-v'] * args.verbose @@ -562,8 +563,7 @@ def sign(self, command, build_dir, build_conf, formats): sign_base += (['-o', out_bin] + sign_config_extra_args + extra_ri_args + args.tool_args + components) - if not args.quiet: - log.inf(quote_sh_list(sign_base)) + command.inf(quote_sh_list(sign_base)) subprocess.check_call(sign_base) if no_manifest: