Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: st: pinctrl.dtsi files including DCMI pins #204

Merged
merged 2 commits into from
May 23, 2024

Conversation

CharlesDias
Copy link
Contributor

@CharlesDias CharlesDias commented May 6, 2024

@CharlesDias CharlesDias force-pushed the dcmi_pinctrl_h7 branch 2 times, most recently from 4921848 to e9c3ee2 Compare May 7, 2024 19:33
@erwango
Copy link
Member

erwango commented May 13, 2024

Looks good to me but would it be possible to generate pins as well for other series?
I know driver is H7 specific for now (at least only validated on H7), but support might be extended in future. Having pins already available would be a good start.
This is the way we're proceeding in general.

@CharlesDias
Copy link
Contributor Author

CharlesDias commented May 16, 2024

Hi, @erwango.

I have two questions about the files generated after run the Python script:

  1. Do I have to add also the new dtsi files related to STM32H523, STM32H533, STM32H7R, and STM32H7s families? Those files are totally new.
  2. I noticed that in stm32h725iekx-pinctrl.dtsi, stm32h725igkx-pinctrl.dtsi, stm32h730ibkxq-pinctrl.dtsi, and stm32h735igkx-pinctrl.dtsi files, the adc3_inp16_ph5 was removed. Do I have to accept this modification? I'll check if something similar happens with other files.

@erwango
Copy link
Member

erwango commented May 17, 2024

Thanks for raising this @CharlesDias.
This probably comes from the fact that you're generating from a latest version of open_pin_data repo.
2 options:

@CharlesDias
Copy link
Contributor Author

Hi, @erwango.

I choose the second option. ;-)

@erwango erwango self-requested a review May 20, 2024 06:45
@erwango
Copy link
Member

erwango commented May 20, 2024

This is fine for me now, but please update the first commit title to remove H7 reference, as pr is stm32 generic now.

@erwango
Copy link
Member

erwango commented May 23, 2024

This is fine for me now, but please update the first commit title to remove H7 reference, as pr is stm32 generic now.

Ping @CharlesDias.
I'm queuing #210

Generate DCMI pin definitions.

Signed-off-by: Charles Dias <[email protected]>
DCMI pins have been generated.

Signed-off-by: Charles Dias <[email protected]>
@CharlesDias CharlesDias changed the title dts: st: h7: pinctrl.dtsi files including DCMI pins dts: st: pinctrl.dtsi files including DCMI pins May 23, 2024
@CharlesDias
Copy link
Contributor Author

This is fine for me now, but please update the first commit title to remove H7 reference, as pr is stm32 generic now.

Hi, @erwango.

Done!

@erwango erwango merged commit c2bc0e6 into zephyrproject-rtos:main May 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants