Bug: Locomotive sprites are cut off on the right side

[DefinitelyNotRau117]

Perhaps the sprites are cut off because they are misaligned in source files

In opengfx(1) the trains are located much higher - the wheels are at the level of the rails

There are also defective pixels on the trains (not all are shown in the picture)

[zephyris]

3 issues here:

1. Vertical alignment in the horizontal view.
   This is arguably an OpenGFX(1) bug. The horizontal sprites are positioned too high, and makes the buy menu glitchy. IMO, a player is more likely to notice misalignments in the buy menu than trains not quite sitting on diagonal rails.
   

2. Front/back cutoff in the horizontal view.
   Seems just to affect monolev engines, except SH125 (which has been updated now anyway). Something to look into.

3. Defective pixels

4. Yeah, there's a weird palette conversion bug somewhere, I'll look into it.

[DefinitelyNotRau117]

1 This is arguably an OpenGFX(1) bug.

Does this mean that the trains will remain in current position relative to the rails?

In newgrf you can set different sprites for the menu and the world, this way it is possible to align the sprites in both ways. If it will not work out for baseset, in my opinion it is better to align trains by the world.

Moreover, the problem with the menu can be circumvented by using a different font or interface size. Misaligned sprites can only be fixed by changing the source files and rebuilding the set.

After all, the game is not about browsing through menus.

[zephyris]

The OpenGFX misalignment (OpenTTD/OpenGFX#83) gets erroneously picked up as a OpenTTD bug
(OpenTTD/OpenTTD#10550)... Definitely a case of "match the original" IMO

[zephyris]

I've checked the monolev engine situation - the OpenGFX1 sprites are oversized relative to standard rail vehicle sizes, which led to them falling out of the sprite bounds. I've tweaked the source sprites to minimise the problem, but they do still overflow by one pixel in several cases. Good enough for now.