[Maker] Don't try to set read only properties

[KDederichs]

Little bit of an DX improvement:

Every time I generate new factories using the make:facrory command it'll try to set createdAt by default even though that value has no setter (it's set in the constructor)

It would be awesome if the maker could skip over those read only properties so I don't have to go through all the factories manually and delete it :D

[nikophil]

Hi @KDederichs

yes, this sounds legit. Do you want to provide a PR?
I think a guard condition should be added in AbstractDefaultPropertyGuesser::addDefaultValueUsingFactory(), maybe using PropertyAccessor::isWritable(), I guess

[KDederichs]

Sure I can look into it, I don't think that's the place for it though since that seems to be where it's adding defaults that are other factories specifically.

Also I don't think you could use PropertyAccessor there since that seems to relay on an object being present and at a quick glance I don't think we have the classname or an instance of it there

[nikophil]

lol yeah sorry you're right, it's not the place to do it...

I wanted to find some place we can make this check once for all...

maybe in MakeFactoryData::getDefaultProperties(), you have everything you need there.

I'm just wondering what to do if always_force_properties: true is configured 🤔 I think, if this option is used, we should not skip those "readonly" properties

[KDederichs]

Hmm getDefaultProperties is probably the right place to filter it out yes, but the fact that the property accessor only takes objects of the thing you want to inspect makes this a lot more complicated that I initially thought it would be.

It'd be all good if you assumed the user only has entities without constructor arguments since you then can grab the class and make a dummy object but I doubt that that's the case in real life :D

As for the always_force_properties probably yes, since the docs say it'll set the property directly without accessing the setters.