-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Audio 10/10] Loose ends #2337
Open
Thar0
wants to merge
19
commits into
zeldaret:main
Choose a base branch
from
Thar0:audio-loose-ends
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+904
−179
Open
[Audio 10/10] Loose ends #2337
Changes from 15 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8e8245e
Introduce afile_sizes, generate headers of sizes for soundfonts and s…
Thar0 01e8323
Initial tools/audio README
Thar0 399182d
Versioning for samplebank extraction
Thar0 dad977f
Clean up the disassemble_sequence.py runnable interface
Thar0 4c3a9b9
Add static assertions for maximum bank sizes
Thar0 a2667d0
Boost optimization for audio tools
Thar0 fb601dc
Samplebank XML doc
Thar0 3a89616
Soundfont XML doc
Thar0 9e3c443
More docs in sampleconv for vadpcm
Thar0 053a74e
Various tools fixes/cleanup
Thar0 d0dc6f1
VADPCM doc
Thar0 79c779e
Try to fix md formatting
Thar0 658a133
VADPCM doc can come later
Thar0 400d996
Fix merge with PR 9
Thar0 c278388
Fix blobs from MM
Thar0 481ede6
Try to fix bss
Thar0 0ca9d2c
Try fix bss round 2
Thar0 7bf26a9
Fix sampleconv memset bug
Thar0 1f817ee
Suggested documentation tweaks
Thar0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
# Samplebank XML Format Specification | ||
|
||
Samplebank XMLs describe a samplebank file that contains compressed waveform data. It specifies which sample files to include as well as certain global properties such as the index of this samplebank. | ||
|
||
--- | ||
|
||
```xml | ||
<SampleBank | ||
Name="<C Indentifier>" | ||
Index="<uint>" | ||
Medium="<Medium>" | ||
CachePolicy="<CachePolicy>" | ||
BufferBug="[bool]" | ||
> | ||
``` | ||
Begins a new samplebank. | ||
|
||
**Properties** | ||
|
||
- **Name**: The name of the samplebank. | ||
- **Index**: The index of the samplebank for the samplebank table. Must be a unique index for all samplebanks and pointers. | ||
- **Medium**: The storage medium, from the SampleMedium enum. | ||
- **CachePolicy**: The cache policy, from the AudioCacheLoadType enum. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. super nit: in the soundfont XML you put |
||
- <ins>[Optional]</ins> **BufferBug**: Whether this samplebank suffers from a buffer clearing bug present in the original audio tools. For matching only. | ||
|
||
**Sub-Attributes** | ||
|
||
- | ||
```xml | ||
<Pointer | ||
Index="<uint>" | ||
/> | ||
``` | ||
Create an alternate index that refers to this samplebank. | ||
|
||
**Properties** | ||
|
||
- **Index**: The alternative index, must be unique among all samplebanks and pointers. | ||
|
||
--- | ||
|
||
- | ||
```xml | ||
<Sample | ||
Name="<C Identifier>" | ||
Path="<Path>" | ||
/> | ||
``` | ||
Adds a **compressed** sample file to the samplebank. The sample should be single-channel and big-endian, in a format that is recognizable by the audio driver such as: pcm16, vadpcm, or half-frame vadpcm. | ||
|
||
**Properties** | ||
|
||
- **Name**: Name of this sample. Must be a valid C language identifier. | ||
- **Path**: Path to aifc file relative to the project root (typically in `$(BUILD_DIR)/assets/audio/samples/`) | ||
|
||
--- | ||
|
||
- | ||
```xml | ||
<Blob | ||
Name="<C Identifier>" | ||
Path="<Path>" | ||
/> | ||
``` | ||
Adds a binary blob to the samplebank. Intended for matching only when data cannot be identified. | ||
|
||
**Properties** | ||
|
||
- **Name**: Name of this blob. Must be a valid C language identifier. | ||
- **Path**: Path to binary file, relative to the project root (typically in `assets/samples/`) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should be |
||
|
||
--- | ||
|
||
```xml | ||
</SampleBank> | ||
``` | ||
--- |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically in XML parlance these are called "attributes", and what's called "Sub-Attributes" below are "tags" (maybe "child tags" or "children"?). I think using the word "properties" is probably fine, but using the word "attribute" for tags could be confusing
(ditto with other XML docs)