func_80183070 to SleepForever #1686
Conversation
hensldm
added
documentation
|
Looks like main needs to be merged in and conflicts resolved. |
| @@ -1,6 +1,6 @@ | |||
| #include "libc64/sleep.h" | |||
|
|
|||
| void func_80183070(void) { | |||
| void Sleep_Forever(void) { | |||
There was a problem hiding this comment.
So taking another look at OoT, they have an additional log message that uses the word freeze which I'm wondering if should actually use in the function name (func_800D31A0 is the function in OoT).
There was a problem hiding this comment.
For reference, OoT (zeldaret/oot#2315) looks to rename the file to sys_freeze (no word on the function yet, though I think just Freeze or Freeze_Forever works) which I agree with.
There was a problem hiding this comment.
I disagree with OoT's decision to call it sys_freeze. The word freeze in the context most appropriate is a system hang, or an unintended fault of software/hardware causing unresponsiveness, and not a deliberate action. Additionally, calling Sleep_Forever does not necessarily result in an unresponsive system.
The "freeze!" comment in OoT more seems like a joke than a hint at the actual source name.
hensldm
added
the
Waiting-for-author
No description provided.