-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoadFragment 2 OK #2
Conversation
Waiting for #3 |
Also moves gOverlayLogSeverity
Small note, it looked like the original place I had |
No longer waiting for #3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this uses -O2 instead of -O2 -g3 like most files it ought to have its own flags specified.
include/load.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is only going to be for loadfragment2 it seems better to name it after the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loadfragment2 isn't the only file that will include this. Any folder that uses Overlay_Relocate
will as well. That I do see a point in naming it something like loadfragment.h
so will do that (I don't really want to add the 2).
Do we want to go the directory route? If so should we go boot_O2 and boot_O2_g3, or just nest O2 and O2_g3 in the boot folder? |
I think I prefer if we went with the directory route. I'm not sure what would be the best way of sorting them, but I kinda like the idea of nesting |
I went with just an O2 folder inside of |
Matches and docs the functions related to overlay relocation. Decided to name the file based off MM, but the functions off OoT. Open to suggestions as always :).