Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report usage of deprecated functions - zeek::confirm_protocol() #1514

Open
awelzel opened this issue Sep 5, 2023 · 1 comment
Open

Report usage of deprecated functions - zeek::confirm_protocol() #1514

awelzel opened this issue Sep 5, 2023 · 1 comment

Comments

@awelzel
Copy link
Contributor

awelzel commented Sep 5, 2023

The zeek::confirm_protocol() method is documented as "deprecated". Compiling a .spicy file with a hook that calls zeek::confirm_protocol() does not trigger a deprecation warning or some form of notification to the user that spicy::accept_input() should be used.

I haven't looked in detail, maybe I'm not using the right flags, but think warning should be produced by default.

@bbannier
Copy link
Member

bbannier commented Sep 5, 2023

This function and zeek::reject_protocol is part of the spicy-plugin functionality in Zeek, https://github.com/zeek/zeek/blob/7e11501d3cdee54482fcce9c9a640cabfe13d2c2/scripts/spicy/zeek.spicy#L9-L20. To trigger a deprecation warning for it we probably would need to add support for a &deprecated attribute to Spicy, decorate these functions, and trigger a message for use of such functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants