-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase ES disk size, Fix tests and fetch correct Camunda version #213
base: main
Are you sure you want to change the base?
Conversation
@rodrigo-lourenco-lopes it is about disk space not memory :D |
236a14b
to
16e76ae
Compare
Ups, I misread the intention. Just corrected it.
@Zelldon also it seems that we are having issues pulling our chart dependency, have you seen this issue before? |
I haven't seen this before 🤔 |
To see the full reasoning check the slack thread: https://camunda.slack.com/archives/C06GF0JPY68/p1732001694427559?thread_ts=1731918845.694709&cid=C06GF0JPY68
This commit also changed the templates and the configuration files, we will have to adapt the templates to this camunda/camunda-platform-helm@28d7927#diff-139e41c5d8eff029161d9db039ef8f0d46df8d6de4e91e42d7abb3c2103ba61a |
The link to the commit in camunda-platform-helm camunda/camunda-platform-helm@28d7927#diff-624a96601c5010c87f441781ea4c0e803b469e0bf2507e7ea86a651b0967ca9d
1c37bae
to
87e0ae0
Compare
@rodrigo-lourenco-lopes can you try to deploy this into a namespace and check whether it comes up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rodrigo-lourenco-lopes I think two or three things we still need to validate
@@ -17,7 +17,7 @@ dependencies: | |||
version: 6.4.0 | |||
condition: "prometheus-elasticsearch-exporter.enabled" | |||
maintainers: | |||
- name: Zelldon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
# Persistent Volume Storage Class | ||
storageClass: "ssd" | ||
# Persistent Volume Size | ||
size: 16Gi | ||
size: 32Gi | ||
# Persistent Volume Access Modes | ||
accessModes: [ "ReadWriteOnce" ] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ I think we have to validate whether the values files also have changed.
@ChrisKujawa It is starting core pods but these are failing to initialize, do we need to change the values.yaml for this? |
Looks to me that a complete new Core section was introduced https://github.com/camunda/camunda-platform-helm/blob/main/charts/camunda-platform-alpha/values.yaml#L1968-L1980 |
I will validate with stakeholders |
Due to some errors of benchmarks out of disk space in ES in some of the latest benchmarks we decided to double it for now.
This PR also addresses #214 fixing the tests related to assuring correct configurations with the golden files.
Closes: #214