Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase ES disk size, Fix tests and fetch correct Camunda version #213

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rodrigo-lourenco-lopes
Copy link
Contributor

@rodrigo-lourenco-lopes rodrigo-lourenco-lopes commented Nov 18, 2024

Due to some errors of benchmarks out of disk space in ES in some of the latest benchmarks we decided to double it for now.

This PR also addresses #214 fixing the tests related to assuring correct configurations with the golden files.

Closes: #214

@ChrisKujawa
Copy link
Member

@rodrigo-lourenco-lopes it is about disk space not memory :D

@rodrigo-lourenco-lopes rodrigo-lourenco-lopes changed the title Increase ES memory for the benchmarks. Increase ES disk size for normal benchmarks. Nov 18, 2024
@rodrigo-lourenco-lopes
Copy link
Contributor Author

@rodrigo-lourenco-lopes it is about disk space not memory :D

Ups, I misread the intention. Just corrected it.

Downloading camunda-platform from repo oci://ghcr.io/camunda/helm
Save error occurred: could not download oci://ghcr.io/camunda/helm/camunda-platform: ghcr.io/camunda/helm/camunda-platform:0.0.0-12.0.0-alpha1: not found
Error: could not download oci://ghcr.io/camunda/helm/camunda-platform: ghcr.io/camunda/helm/camunda-platform:0.0.0-12.0.0-alpha1: not found

@Zelldon also it seems that we are having issues pulling our chart dependency, have you seen this issue before?

@ChrisKujawa
Copy link
Member

@rodrigo-lourenco-lopes it is about disk space not memory :D

Ups, I misread the intention. Just corrected it.

Downloading camunda-platform from repo oci://ghcr.io/camunda/helm
Save error occurred: could not download oci://ghcr.io/camunda/helm/camunda-platform: ghcr.io/camunda/helm/camunda-platform:0.0.0-12.0.0-alpha1: not found
Error: could not download oci://ghcr.io/camunda/helm/camunda-platform: ghcr.io/camunda/helm/camunda-platform:0.0.0-12.0.0-alpha1: not found

@Zelldon also it seems that we are having issues pulling our chart dependency, have you seen this issue before?

I haven't seen this before 🤔

@rodrigo-lourenco-lopes
Copy link
Contributor Author

This commit also changed the templates and the configuration files, we will have to adapt the templates to this camunda/camunda-platform-helm@28d7927#diff-139e41c5d8eff029161d9db039ef8f0d46df8d6de4e91e42d7abb3c2103ba61a

@rodrigo-lourenco-lopes rodrigo-lourenco-lopes changed the title Increase ES disk size for normal benchmarks. Increase ES disk size, Fix tests and fetch correct Camunda version Nov 21, 2024
@ChrisKujawa
Copy link
Member

@rodrigo-lourenco-lopes can you try to deploy this into a namespace and check whether it comes up?

Copy link
Member

@ChrisKujawa ChrisKujawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rodrigo-lourenco-lopes I think two or three things we still need to validate

@@ -17,7 +17,7 @@ dependencies:
version: 6.4.0
condition: "prometheus-elasticsearch-exporter.enabled"
maintainers:
- name: Zelldon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Comment on lines 525 to 531
# Persistent Volume Storage Class
storageClass: "ssd"
# Persistent Volume Size
size: 16Gi
size: 32Gi
# Persistent Volume Access Modes
accessModes: [ "ReadWriteOnce" ]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ I think we have to validate whether the values files also have changed.

@rodrigo-lourenco-lopes
Copy link
Contributor Author

@ChrisKujawa It is starting core pods but these are failing to initialize, do we need to change the values.yaml for this?
The other pods seem to initialize correctly.

@ChrisKujawa
Copy link
Member

@ChrisKujawa It is starting core pods but these are failing to initialize, do we need to change the values.yaml for this? The other pods seem to initialize correctly.

Looks to me that a complete new Core section was introduced https://github.com/camunda/camunda-platform-helm/blob/main/charts/camunda-platform-alpha/values.yaml#L1968-L1980

@ChrisKujawa
Copy link
Member

@ChrisKujawa It is starting core pods but these are failing to initialize, do we need to change the values.yaml for this?
The other pods seem to initialize correctly.

I will validate with stakeholders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix golden files tests after Camunda-platform-helm Changes
2 participants