Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when closing one window #17684

Closed
1 task done
VitorRamos opened this issue Sep 11, 2024 · 4 comments
Closed
1 task done

Crash when closing one window #17684

VitorRamos opened this issue Sep 11, 2024 · 4 comments
Labels
bug [core label] linux linux-wayland Linux Wayland panic / crash [core label] workspace Feedback for workspace management, layout, interactions, etc

Comments

@VitorRamos
Copy link
Contributor

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Similar to #17005

  1. Opening three windows with zed (workspace new windows)
  2. Close one of them.
  3. Crashes

Environment

Zed: v0.153.1 (Zed Preview)
OS: Linux Wayland ubuntu 24.04
Memory: 31.2 GiB
Architecture: x86_64
GPU: NVIDIA GeForce RTX 2070 with Max-Q Design || NVIDIA || 550.107.02

If applicable, add mockups / screenshots to help explain present your vision of the feature

Stack trace from main (ec189fe)

Thread 1 "zed" received signal SIGSEGV, Segmentation fault.
0x0000000000000000 in ?? ()
#0  0x0000000000000000 in ?? ()
#1  0x00007fffbed09cfc in ?? () from /lib/x86_64-linux-gnu/libnvidia-glcore.so.550.107.02
#2  0x00007fffbef25125 in ?? () from /lib/x86_64-linux-gnu/libnvidia-glcore.so.550.107.02
#3  0x00007ffff5b73a55 in ?? () from /lib/x86_64-linux-gnu/libGLX_nvidia.so.0
#4  0x0000555561da405b in ash::extensions_generated::khr::swapchain::Device::acquire_next_image () at /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ash-0.38.0+1.3.281/src/extensions/khr/swapchain.rs:62
#5  0x0000555561d6df68 in blade_graphics::hal::Context::acquire_frame () at src/vulkan/init.rs:1081
#6  0x00005555615f21a9 in gpui::platform::blade::blade_renderer::BladeRenderer::draw () at crates/gpui/src/platform/blade/blade_renderer.rs:566
#7  0x00005555615cc58c in gpui::platform::linux::wayland::window::{impl#8}::draw () at crates/gpui/src/platform/linux/wayland/window.rs:943
#8  0x0000555561784e14 in gpui::window::WindowContext::present () at crates/gpui/src/window.rs:1498
#9  0x000055556165a43e in gpui::window::{impl#19}::new::{closure#4}::{closure#1}::{closure#0} () at crates/gpui/src/window.rs:706
#10 0x00005555613de100 in gpui::app::{impl#5}::update_window::{closure#0}<(), gpui::window::{impl#19}::new::{closure#4}::{closure#1}::{closure_env#0}> () at crates/gpui/src/app.rs:1385
#11 0x00005555613d0b51 in gpui::app::AppContext::update<core::result::Result<(), anyhow::Error>, gpui::app::{impl#5}::update_window::{closure_env#0}<(), gpui::window::{impl#19}::new::{closure#4}::{closure#1}::{closure_env#0}>> () at crates/gpui/src/app.rs:354
#12 0x00005555613d2dd7 in gpui::app::{impl#5}::update_window<(), gpui::window::{impl#19}::new::{closure#4}::{closure#1}::{closure_env#0}> () at crates/gpui/src/app.rs:1376
#13 0x00005555613c8f9b in gpui::app::async_context::{impl#0}::update_window<(), gpui::window::{impl#19}::new::{closure#4}::{closure#1}::{closure_env#0}> () at crates/gpui/src/app/async_context.rs:91
#14 0x0000555561683776 in gpui::window::AnyWindowHandle::update<gpui::app::async_context::AsyncAppContext, (), gpui::window::{impl#19}::new::{closure#4}::{closure#1}::{closure_env#0}> () at crates/gpui/src/window.rs:4774
#15 0x000055556165a3db in gpui::window::{impl#19}::new::{closure#4}::{closure#1} () at crates/gpui/src/window.rs:703
#16 0x0000555561701e7c in util::measure<(), gpui::window::{impl#19}::new::{closure#4}::{closure_env#1}> () at crates/util/src/util.rs:327
#17 0x000055556165a138 in gpui::window::{impl#19}::new::{closure#4} () at crates/gpui/src/window.rs:702
#18 0x000055556124df6e in alloc::boxed::{impl#49}::call_mut<(), dyn core::ops::function::FnMut<(), Output=()>, alloc::alloc::Global> () at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/alloc/src/boxed.rs:2077
#19 0x00005555615c566e in gpui::platform::linux::wayland::window::WaylandWindowStatePtr::frame () at crates/gpui/src/platform/linux/wayland/window.rs:326
#20 0x0000555561475719 in gpui::platform::linux::wayland::client::{impl#7}::event () at crates/gpui/src/platform/linux/wayland/client.rs:873
#21 0x000055556149b414 in wayland_client::event_queue::queue_callback<wayland_client::protocol::wl_callback::WlCallback, wayland_backend::sys::client::ObjectId, gpui::platform::linux::wayland::client::WaylandClientStatePtr> () at /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wayland-client-0.31.5/src/event_queue.rs:660
#22 0x000055556149f2ac in wayland_client::event_queue::EventQueue::dispatching_impl<gpui::platform::linux::wayland::client::WaylandClientStatePtr> () at /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wayland-client-0.31.5/src/event_queue.rs:482
#23 0x000055556149f1bb in wayland_client::event_queue::EventQueue::dispatch_pending<gpui::platform::linux::wayland::client::WaylandClientStatePtr> () at /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wayland-client-0.31.5/src/event_queue.rs:388
#24 0x00005555614342ff in calloop_wayland_source::{impl#0}::insert::{closure#0}<gpui::platform::linux::wayland::client::WaylandClientStatePtr> () at /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/calloop-wayland-source-0.3.0/src/lib.rs:115
#25 0x00005555614982ee in calloop::sources::{impl#4}::process_events::{closure#0}<gpui::platform::linux::wayland::client::WaylandClientStatePtr, calloop_wayland_source::WaylandSource<gpui::platform::linux::wayland::client::WaylandClientStatePtr>, calloop_wayland_source::{impl#0}::insert::{closure_env#0}<gpui::platform::linux::wayland::client::WaylandClientStatePtr>> () at /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/calloop-0.13.0/src/sources/mod.rs:327
#26 0x0000555561433d56 in calloop_wayland_source::WaylandSource::loop_callback_pending<gpui::platform::linux::wayland::client::WaylandClientStatePtr, calloop::sources::{impl#4}::process_events::{closure_env#0}<gpui::platform::linux::wayland::client::WaylandClientStatePtr, calloop_wayland_source::WaylandSource<gpui::platform::linux::wayland::client::WaylandClientStatePtr>, calloop_wayland_source::{impl#0}::insert::{closure_env#0}<gpui::platform::linux::wayland::client::WaylandClientStatePtr>>> () at /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/calloop-wayland-source-0.3.0/src/lib.rs:245
#27 0x000055556144b51d in calloop_wayland_source::{impl#1}::process_events<gpui::platform::linux::wayland::client::WaylandClientStatePtr, calloop::sources::{impl#4}::process_events::{closure_env#0}<gpui::platform::linux::wayland::client::WaylandClientStatePtr, calloop_wayland_source::WaylandSource<gpui::platform::linux::wayland::client::WaylandClientStatePtr>, calloop_wayland_source::{impl#0}::insert::{closure_env#0}<gpui::platform::linux::wayland::client::WaylandClientStatePtr>>> () at /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/calloop-wayland-source-0.3.0/src/lib.rs:154
#28 0x000055556136d68c in calloop::sources::{impl#4}::process_events<gpui::platform::linux::wayland::client::WaylandClientStatePtr, calloop_wayland_source::WaylandSource<gpui::platform::linux::wayland::client::WaylandClientStatePtr>, calloop_wayland_source::{impl#0}::insert::{closure_env#0}<gpui::platform::linux::wayland::client::WaylandClientStatePtr>> () at /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/calloop-0.13.0/src/sources/mod.rs:326
#29 0x000055556170fec4 in calloop::loop_logic::EventLoop::dispatch_events<gpui::platform::linux::wayland::client::WaylandClientStatePtr> () at /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/calloop-0.13.0/src/loop_logic.rs:445
#30 0x0000555561716b91 in calloop::loop_logic::EventLoop::dispatch<gpui::platform::linux::wayland::client::WaylandClientStatePtr, core::option::Option<core::time::Duration>> () at /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/calloop-0.13.0/src/loop_logic.rs:559
#31 0x0000555561714e47 in calloop::loop_logic::EventLoop::run<gpui::platform::linux::wayland::client::WaylandClientStatePtr, gpui::platform::linux::wayland::client::{impl#5}::run::{closure_env#0}, core::option::Option<core::time::Duration>> () at /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/calloop-0.13.0/src/loop_logic.rs:596
#32 0x0000555561473f83 in gpui::platform::linux::wayland::client::{impl#5}::run () at crates/gpui/src/platform/linux/wayland/client.rs:712
#33 0x000055556175f759 in gpui::platform::linux::platform::{impl#1}::run<gpui::platform::linux::wayland::client::WaylandClient> () at crates/gpui/src/platform/linux/platform.rs:145
#34 0x0000555559e6c3aa in gpui::app::App::run<zed::main::{closure_env#3}> () at crates/gpui/src/app.rs:153
#35 0x0000555559ee9a76 in zed::main () at crates/zed/src/main.rs:434

If applicable, attach your Zed.log file to this issue.

Zed.log
@VitorRamos VitorRamos added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Sep 11, 2024
@Moshyfawn Moshyfawn added panic / crash [core label] workspace Feedback for workspace management, layout, interactions, etc linux linux-wayland Linux Wayland and removed triage Maintainer needs to classify the issue labels Sep 14, 2024
@notpeter
Copy link
Member

In #17863 @TheSgtPepper23 reported the same issue. Of note they are using v560 of the driver while the reporter her is using v550.

Zed: v0.152.3 (Zed)
OS: Linux Wayland arch unknown
Memory: 31.3 GiB
Architecture: x86_64
GPU: NVIDIA GeForce RTX 3060 Ti || NVIDIA || 560.35.03

This issue was also reported in a comment on this issue as well:

@notpeter notpeter removed the admin read Pending admin review label Sep 16, 2024
@ridhwaanm
Copy link

same issue
zed-0.160.7-1.fc41.x86_64 (terra41 stable)
OS: Fedora Linux 6.11.7-300.fc41.x86_64
Display Server: wayland
NVIDIA GeForce RTX 3070 Ti
Driver Version: 565.57.01 CUDA Version: 12.7

Not sure if related but have been seeing the same issue with ptyxis terminal emulator when closing when more than one tab is open

@TheSgtPepper23
Copy link

Im pretty sure this is a wayland issue, since I reported the bug I switched back to X11 and no longer have this problem. I just checked.

@notpeter
Copy link
Member

Closing in favor of:

Because it has more upvotes and is older.
Thanks for reporting and please 👍 vote!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] linux linux-wayland Linux Wayland panic / crash [core label] workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Development

No branches or pull requests

5 participants