Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: fix(ls): fix missing ls command #671

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: fix(ls): fix missing ls command #671

wants to merge 1 commit into from

Conversation

turboBasic
Copy link

@turboBasic turboBasic commented Sep 27, 2024 •
edited
Loading

Description

Related Issue(s)

This PR is fixes #670

Motivation and Context

Fix missing zinit ls command

Usage examples

zunit tests/ls.zunit

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed. ⚠️ No, test for zinit ls currently fails
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@turboBasic turboBasic mentioned this pull request Sep 27, 2024
Open
1 task
@turboBasic
Copy link
Author

turboBasic commented Sep 27, 2024 •
edited
Loading

I see that the new tests added to tests/ dir are not automatically executed by test runner.

I have moved contents of ls.zunit inside tests/commands.zunit so that failing test is visible in GitHub Actions

@turboBasic turboBasic force-pushed the fix/missing-ls-command branch from a3347ce to 32dd771 Compare September 27, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alichtman alichtman Awaiting requested review from alichtman alichtman will be requested when the pull request is marked ready for review alichtman is a code owner

@pschmitt pschmitt Awaiting requested review from pschmitt pschmitt will be requested when the pull request is marked ready for review pschmitt is a code owner

@vladdoster vladdoster Awaiting requested review from vladdoster vladdoster will be requested when the pull request is marked ready for review vladdoster is a code owner

Assignees
No one assigned
Labels
fix release tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: zinit ls command is missing
1 participant
@turboBasic