feat: add metadata.annotations to v1alpha1 schema
#3044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshall007
changed the title
metadata.annotations to v1alpha1 schemametadata.annotations to v1alpha1 schema
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Marshall Cottrell <[email protected]>
Signed-off-by: Marshall Cottrell <[email protected]>
marshall007
force-pushed
the
marshall/annotations-alpha
branch
from
fb6350c to
7e847b3
Compare
marshall007
commented
Sep 27, 2024
Comment on lines
+114
to
+116
| // annotations explicitly defined in `metadata.annotations` take precedence over legacy fields | ||
| maps.Copy(annotations, metadata.Annotations) | ||
|
|
There was a problem hiding this comment.
I could not find any existing tests for populating annotations on the OCI manifest and config. Happy to add some if there is an obvious place to do that.
There was a problem hiding this comment.
Yeah there aren't currently any tests that verify that annotations end up on the manifest or manifest config
Codecov ReportAttention: Patch coverage is
|
AustinAbro321
approved these changes
Sep 27, 2024
phillebaba
requested changes
Sep 28, 2024
|
Thank you for this contribution, but due to the work we are planning on v1.0 this may conflict with our own implementations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds
metadata.annotationsfromv1beta1to the existingv1alpha1schema. It also adds them to the OCI config descriptor and image manifests.Related Issue
Relates to #2976.
Checklist before merging