Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor use of in memory registry in e2e test #2877

Open
AustinAbro321 opened this issue Aug 13, 2024 · 0 comments
Open

Refactor use of in memory registry in e2e test #2877

AustinAbro321 opened this issue Aug 13, 2024 · 0 comments

Comments

@AustinAbro321
Copy link
Contributor

Describe what should be investigated or refactored

#2869 changed the OCI e2e tests use a in memory database as we saw flakes during the EKS tests relating to connection resets on docker timeouts (#2837). There are a few things we may want to reconsider / refactor from this implementation however.

  1. The distribution/distribution registry code doesn't give a way to close the server without sending a sigint to the server (as far as I can tell) . It's unclear when the server cleans up the resources.
  2. All OCI artifacts are stored in memory, this shouldn't be a huge issue as the largest package currently in the test is 27mb, but this is something to be wary of if we test with larger packages.
  3. We don't check the error from starting the registry server as it's in a go-routine. Potentially this could be resolved using error groups.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants