Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved image push progress bar support for long image names #2651

Closed
blancharda opened this issue Jun 20, 2024 · 2 comments · Fixed by #2965
Closed

Improved image push progress bar support for long image names #2651

blancharda opened this issue Jun 20, 2024 · 2 comments · Fixed by #2965
Assignees
Labels
enhancement ✨ New feature or request
Milestone

Comments

@blancharda
Copy link

Is your feature request related to a problem? Please describe.

When pushing images with long paths, the Zarf image push output tends to strobe between Pushing <x> images and a truncated message with the name of the image (shown in the video below).

I believe this may be a result of the default max line width (100c) in the progress bar.

Ironbank images (as a common example) tend to be quite long due to the repository folder structure:

registry1.dso.mil/ironbank/tetrate/istio/proxyv2:1.22.1-tetratefips-v0-zarf-3754112098

At 87 characters^, this image name leaves little room on the progress bar line.

Proposed solution(s)

  • Increase the default width to 120 characters (or some other arbitrary length to support longer format image names)
  • Separate the progress bar output from the name of the image being pushed (more lines)

Additional context

Example:
https://github.com/defenseunicorns/zarf/assets/9499393/7d27784e-0bcc-4889-8e6f-d6eef6d0a8a0

@blancharda blancharda added the enhancement ✨ New feature or request label Jun 20, 2024
@phillebaba
Copy link
Member

Worth considering for #2588

@salaxander salaxander added this to Zarf Jul 22, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Zarf Jul 22, 2024
@salaxander salaxander removed the status in Zarf Jul 22, 2024
@AustinAbro321
Copy link
Contributor

This is actually not related to long image names. The flashing happens regardless. I believe I have a solution

@salaxander salaxander moved this to In review in Zarf Sep 4, 2024
@salaxander salaxander added this to the v0.39.0 milestone Sep 4, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Zarf Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants