pscanrules: add examples alerts to Insecure JSF ViewState #5688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
|
I have read the CLA Document and I hereby sign the CLA |
|
It's only necessary to comment once. |
kingthorin
reviewed
Aug 31, 2024
.../src/main/java/org/zaproxy/zap/extension/pscanrules/InsecureJsfViewStatePassiveScanRule.java
Outdated
Show resolved
Hide resolved
|
To address the build failure: |
thc202
changed the title
thc202
reviewed
Sep 1, 2024
.../src/main/java/org/zaproxy/zap/extension/pscanrules/InsecureJsfViewStatePassiveScanRule.java
Outdated
Show resolved
Hide resolved
3 tasks
anaaroch
force-pushed
the
main
branch
3 times, most recently
from
658cdf9
to
e1c4126
Compare
anaaroch
force-pushed
the
main
branch
2 times, most recently
from
2975fe7
to
81a1abf
Compare
|
I believe the suggestions have been resolved. |
thc202
reviewed
Sep 4, 2024
thc202
reviewed
Sep 4, 2024
...t/java/org/zaproxy/zap/extension/pscanrules/InsecureJsfViewStatePassiveScanRuleUnitTest.java
Outdated
Show resolved
Hide resolved
|
Needs a spotlessApply again |
|
Has conflicts that must be resolved before it can be merged. |
|
Note there's also a commit that should have the author reset. |
Signed-off-by: Ana Rocha <[email protected]> Co-authored-by: Lucas Bergholz <[email protected]>
|
Conflict addressed and author reset. |
thc202
approved these changes
Sep 16, 2024
|
Thank you @anaaroch and @LucasBergholz! |
kingthorin
approved these changes
Sep 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Me and Lucas Bergholz worked on this together, with the porpuse of adding the alert for Insecure JSF ViewState - P. We are open for any feedbacks of our work, as this is our first contribution on this issue.
Related Issues
Part of zaproxy/zaproxy#6119.
Checklist
./gradlew spotlessApplyfor code formattingFor more details, please refer to the developer rules and guidelines.