-
-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ascanrulesBeta: Add more example alerts #5291
Conversation
...ta/src/main/resources/org/zaproxy/zap/extension/ascanrulesBeta/resources/Messages.properties
Outdated
Show resolved
Hide resolved
96e2490
to
5c35ae5
Compare
Thank you! |
#the refs cannot be customised for each sub-category (Adobe, Silverlight, etc.) | ||
ascanbeta.crossdomain.refs = http://www.adobe.com/devnet/articles/crossdomain_policy_file_spec.html\nhttp://www.adobe.com/devnet-docs/acrobatetk/tools/AppSec/CrossDomain_PolicyFile_Specification.pdf\nhttp://msdn.microsoft.com/en-US/library/cc197955%28v=vs.95%29.aspx\nhttp://msdn.microsoft.com/en-us/library/cc838250%28v=vs.95%29.aspx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dropped the comment about sub-cats, they could be. It's 2024 and we should not be encountering flash anymore. (I think Silverlight is EOL too??? I'd have to dig) That's not 100% sure but it's close. I don't think there's much point splitting the refs up, as this rule should probably be retired <air_quotes>soon</air_quotes>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file is not just about Flash though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's flash and silver light but I believe SL is rolling or headed roll as well.
Either way the comment is no longer necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean the Adobe file is not just for Flash, it's for other Adobe programs too (not arguing against just saying).
Agreed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay, I didn't realize they had other techs using it.
- CHANGELOG > Add change notes. - Scan rules > Add example alert functionality (6119). - Unit tests > Assert the new example alerts. - Messages.properties > Updated some http references (8262). Signed-off-by: kingthorin <[email protected]>
5c35ae5
to
a1f5eb7
Compare
Force pushed to kick WIP |
Overview
Related Issues
Checklist
./gradlew spotlessApply
for code formatting