Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ascanrulesBeta: Add more example alerts #5291

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

kingthorin
Copy link
Member

Overview

  • CHANGELOG > Add change notes.
  • Scan rules > Add example alert functionality (6119).
  • Unit tests > Assert the new example alerts.
  • Messages.properties > Updated some http references (8262).

Related Issues

Checklist

  • [NA] Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

@thc202
Copy link
Member

thc202 commented Feb 12, 2024

Thank you!

Comment on lines -38 to -39
#the refs cannot be customised for each sub-category (Adobe, Silverlight, etc.)
ascanbeta.crossdomain.refs = http://www.adobe.com/devnet/articles/crossdomain_policy_file_spec.html\nhttp://www.adobe.com/devnet-docs/acrobatetk/tools/AppSec/CrossDomain_PolicyFile_Specification.pdf\nhttp://msdn.microsoft.com/en-US/library/cc197955%28v=vs.95%29.aspx\nhttp://msdn.microsoft.com/en-us/library/cc838250%28v=vs.95%29.aspx
Copy link
Member Author

@kingthorin kingthorin Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped the comment about sub-cats, they could be. It's 2024 and we should not be encountering flash anymore. (I think Silverlight is EOL too??? I'd have to dig) That's not 100% sure but it's close. I don't think there's much point splitting the refs up, as this rule should probably be retired <air_quotes>soon</air_quotes>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is not just about Flash though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's flash and silver light but I believe SL is rolling or headed roll as well.

Either way the comment is no longer necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the Adobe file is not just for Flash, it's for other Adobe programs too (not arguing against just saying).

Agreed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay, I didn't realize they had other techs using it.

- CHANGELOG > Add change notes.
- Scan rules > Add example alert functionality (6119).
- Unit tests > Assert the new example alerts.
- Messages.properties > Updated some http references (8262).

Signed-off-by: kingthorin <[email protected]>
@kingthorin
Copy link
Member Author

Force pushed to kick WIP

@thc202 thc202 merged commit 3505c9b into zaproxy:main Feb 13, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
@kingthorin kingthorin deleted the oui-more-examples branch February 13, 2024 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants