Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allows the use of Docker Volume Mount for /zap/wrk/ #81

Open
lloyd-j0nes opened this issue Jul 1, 2022 · 0 comments
Open

Feature: Allows the use of Docker Volume Mount for /zap/wrk/ #81

lloyd-j0nes opened this issue Jul 1, 2022 · 0 comments

Comments

@lloyd-j0nes
Copy link

Hi ZAProxy team,

First off, amazing work on this! It's really slick and I'm loving how simple it is to use.

We currently use GitHub Enterprise on-premise, with runners that are containerized. This presents a problem when trying to do bind mounts for the /zap/wrk directory, as the container can't bind mount its own filesystem to another container. Would it be feasible to allow overriding the -v argument in the docker command that's currently set to ${workspace}/process.env.GITHUB_WORKSPACE?

From:

let workspace = process.env.GITHUB_WORKSPACE; 
let command = ('docker run -v ${workspace}:/zap/wrk/:rw --network="host"  +

To:

<Check for storagesrc variable, if not set, default to process.env.GITHUB_WORKSPACE>
let command = ('docker run -v ${storagesrc}:/zap/wrk/:rw --network="host"  +

For example, if we could pass the name of a docker volume or our own path, that would resolve this issue. Other may run into this if they are using their own containerized/on-prem environments, so it may be useful in other cases as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant