From fa5778f7be3646e3f6881c287f2574d1e3df7627 Mon Sep 17 00:00:00 2001 From: Alberto Moretti Date: Tue, 14 Nov 2023 10:40:44 +0100 Subject: [PATCH 1/4] Update NotificationType enum values --- pkg/platform/v1/task.pb.go | 42 ++++++++++++++++++------------------ proto/platform/v1/task.proto | 4 ++-- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/pkg/platform/v1/task.pb.go b/pkg/platform/v1/task.pb.go index e5c1de3..81fb079 100644 --- a/pkg/platform/v1/task.pb.go +++ b/pkg/platform/v1/task.pb.go @@ -84,11 +84,11 @@ func (TaskType) EnumDescriptor() ([]byte, []int) { type NotificationType int32 const ( - NotificationType_NOTIFICATION_TYPE_UNSPECIFIED NotificationType = 0 - NotificationType_NOTIFICATION_TYPE_DATA_COMPLETE NotificationType = 1 - NotificationType_NOTIFICATION_TYPE_DATA_TIMEOUT_1 NotificationType = 2 - NotificationType_NOTIFICATION_TYPE_DATA_TIMEOUT_2 NotificationType = 3 - NotificationType_NOTIFICATION_TYPE_TRIGGER NotificationType = 4 + NotificationType_NOTIFICATION_TYPE_UNSPECIFIED NotificationType = 0 + NotificationType_NOTIFICATION_TYPE_DATA_COMPLETE NotificationType = 1 + NotificationType_NOTIFICATION_TYPE_DATA_TIMEOUT_SHORT NotificationType = 2 + NotificationType_NOTIFICATION_TYPE_DATA_TIMEOUT_MEDIUM NotificationType = 3 + NotificationType_NOTIFICATION_TYPE_TRIGGER NotificationType = 4 ) // Enum value maps for NotificationType. @@ -96,16 +96,16 @@ var ( NotificationType_name = map[int32]string{ 0: "NOTIFICATION_TYPE_UNSPECIFIED", 1: "NOTIFICATION_TYPE_DATA_COMPLETE", - 2: "NOTIFICATION_TYPE_DATA_TIMEOUT_1", - 3: "NOTIFICATION_TYPE_DATA_TIMEOUT_2", + 2: "NOTIFICATION_TYPE_DATA_TIMEOUT_SHORT", + 3: "NOTIFICATION_TYPE_DATA_TIMEOUT_MEDIUM", 4: "NOTIFICATION_TYPE_TRIGGER", } NotificationType_value = map[string]int32{ - "NOTIFICATION_TYPE_UNSPECIFIED": 0, - "NOTIFICATION_TYPE_DATA_COMPLETE": 1, - "NOTIFICATION_TYPE_DATA_TIMEOUT_1": 2, - "NOTIFICATION_TYPE_DATA_TIMEOUT_2": 3, - "NOTIFICATION_TYPE_TRIGGER": 4, + "NOTIFICATION_TYPE_UNSPECIFIED": 0, + "NOTIFICATION_TYPE_DATA_COMPLETE": 1, + "NOTIFICATION_TYPE_DATA_TIMEOUT_SHORT": 2, + "NOTIFICATION_TYPE_DATA_TIMEOUT_MEDIUM": 3, + "NOTIFICATION_TYPE_TRIGGER": 4, } ) @@ -364,21 +364,21 @@ var file_proto_platform_v1_task_proto_rawDesc = []byte{ 0x54, 0x4f, 0x50, 0x4f, 0x4c, 0x4f, 0x47, 0x59, 0x10, 0x02, 0x12, 0x13, 0x0a, 0x0f, 0x54, 0x41, 0x53, 0x4b, 0x5f, 0x54, 0x59, 0x50, 0x45, 0x5f, 0x53, 0x54, 0x41, 0x54, 0x45, 0x10, 0x03, 0x12, 0x13, 0x0a, 0x0f, 0x54, 0x41, 0x53, 0x4b, 0x5f, 0x54, 0x59, 0x50, 0x45, 0x5f, 0x46, 0x41, 0x55, - 0x4c, 0x54, 0x10, 0x04, 0x2a, 0xc5, 0x01, 0x0a, 0x10, 0x4e, 0x6f, 0x74, 0x69, 0x66, 0x69, 0x63, + 0x4c, 0x54, 0x10, 0x04, 0x2a, 0xce, 0x01, 0x0a, 0x10, 0x4e, 0x6f, 0x74, 0x69, 0x66, 0x69, 0x63, 0x61, 0x74, 0x69, 0x6f, 0x6e, 0x54, 0x79, 0x70, 0x65, 0x12, 0x21, 0x0a, 0x1d, 0x4e, 0x4f, 0x54, 0x49, 0x46, 0x49, 0x43, 0x41, 0x54, 0x49, 0x4f, 0x4e, 0x5f, 0x54, 0x59, 0x50, 0x45, 0x5f, 0x55, 0x4e, 0x53, 0x50, 0x45, 0x43, 0x49, 0x46, 0x49, 0x45, 0x44, 0x10, 0x00, 0x12, 0x23, 0x0a, 0x1f, 0x4e, 0x4f, 0x54, 0x49, 0x46, 0x49, 0x43, 0x41, 0x54, 0x49, 0x4f, 0x4e, 0x5f, 0x54, 0x59, 0x50, 0x45, 0x5f, 0x44, 0x41, 0x54, 0x41, 0x5f, 0x43, 0x4f, 0x4d, 0x50, 0x4c, 0x45, 0x54, 0x45, 0x10, - 0x01, 0x12, 0x24, 0x0a, 0x20, 0x4e, 0x4f, 0x54, 0x49, 0x46, 0x49, 0x43, 0x41, 0x54, 0x49, 0x4f, + 0x01, 0x12, 0x28, 0x0a, 0x24, 0x4e, 0x4f, 0x54, 0x49, 0x46, 0x49, 0x43, 0x41, 0x54, 0x49, 0x4f, 0x4e, 0x5f, 0x54, 0x59, 0x50, 0x45, 0x5f, 0x44, 0x41, 0x54, 0x41, 0x5f, 0x54, 0x49, 0x4d, 0x45, - 0x4f, 0x55, 0x54, 0x5f, 0x31, 0x10, 0x02, 0x12, 0x24, 0x0a, 0x20, 0x4e, 0x4f, 0x54, 0x49, 0x46, - 0x49, 0x43, 0x41, 0x54, 0x49, 0x4f, 0x4e, 0x5f, 0x54, 0x59, 0x50, 0x45, 0x5f, 0x44, 0x41, 0x54, - 0x41, 0x5f, 0x54, 0x49, 0x4d, 0x45, 0x4f, 0x55, 0x54, 0x5f, 0x32, 0x10, 0x03, 0x12, 0x1d, 0x0a, - 0x19, 0x4e, 0x4f, 0x54, 0x49, 0x46, 0x49, 0x43, 0x41, 0x54, 0x49, 0x4f, 0x4e, 0x5f, 0x54, 0x59, - 0x50, 0x45, 0x5f, 0x54, 0x52, 0x49, 0x47, 0x47, 0x45, 0x52, 0x10, 0x04, 0x42, 0x0f, 0x5a, 0x0d, - 0x2e, 0x2f, 0x70, 0x6c, 0x61, 0x74, 0x66, 0x6f, 0x72, 0x6d, 0x2f, 0x76, 0x31, 0x62, 0x06, 0x70, - 0x72, 0x6f, 0x74, 0x6f, 0x33, + 0x4f, 0x55, 0x54, 0x5f, 0x53, 0x48, 0x4f, 0x52, 0x54, 0x10, 0x02, 0x12, 0x29, 0x0a, 0x25, 0x4e, + 0x4f, 0x54, 0x49, 0x46, 0x49, 0x43, 0x41, 0x54, 0x49, 0x4f, 0x4e, 0x5f, 0x54, 0x59, 0x50, 0x45, + 0x5f, 0x44, 0x41, 0x54, 0x41, 0x5f, 0x54, 0x49, 0x4d, 0x45, 0x4f, 0x55, 0x54, 0x5f, 0x4d, 0x45, + 0x44, 0x49, 0x55, 0x4d, 0x10, 0x03, 0x12, 0x1d, 0x0a, 0x19, 0x4e, 0x4f, 0x54, 0x49, 0x46, 0x49, + 0x43, 0x41, 0x54, 0x49, 0x4f, 0x4e, 0x5f, 0x54, 0x59, 0x50, 0x45, 0x5f, 0x54, 0x52, 0x49, 0x47, + 0x47, 0x45, 0x52, 0x10, 0x04, 0x42, 0x0f, 0x5a, 0x0d, 0x2e, 0x2f, 0x70, 0x6c, 0x61, 0x74, 0x66, + 0x6f, 0x72, 0x6d, 0x2f, 0x76, 0x31, 0x62, 0x06, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x33, } var ( diff --git a/proto/platform/v1/task.proto b/proto/platform/v1/task.proto index 0b237f6..812cc17 100644 --- a/proto/platform/v1/task.proto +++ b/proto/platform/v1/task.proto @@ -24,8 +24,8 @@ enum TaskType { enum NotificationType { NOTIFICATION_TYPE_UNSPECIFIED = 0; NOTIFICATION_TYPE_DATA_COMPLETE = 1; - NOTIFICATION_TYPE_DATA_TIMEOUT_1 = 2; - NOTIFICATION_TYPE_DATA_TIMEOUT_2 = 3; + NOTIFICATION_TYPE_DATA_TIMEOUT_SHORT = 2; + NOTIFICATION_TYPE_DATA_TIMEOUT_MEDIUM = 3; NOTIFICATION_TYPE_TRIGGER = 4; } From b53da213febf07f2ce5b51cb53962dadd1853305 Mon Sep 17 00:00:00 2001 From: Alberto Moretti Date: Tue, 14 Nov 2023 10:47:54 +0100 Subject: [PATCH 2/4] docs: update docs --- docs/task.proto.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/task.proto.md b/docs/task.proto.md index 0eedb7a..6310e6a 100644 --- a/docs/task.proto.md +++ b/docs/task.proto.md @@ -40,8 +40,8 @@ |----------------------------------|---------|-------------| | NOTIFICATION_TYPE_UNSPECIFIED | 0 | | | NOTIFICATION_TYPE_DATA_COMPLETE | 1 | | -| NOTIFICATION_TYPE_DATA_TIMEOUT_1 | 2 | | -| NOTIFICATION_TYPE_DATA_TIMEOUT_2 | 3 | | +| NOTIFICATION_TYPE_DATA_TIMEOUT_SHORT | 2 | | +| NOTIFICATION_TYPE_DATA_TIMEOUT_MEDIUM | 3 | | | NOTIFICATION_TYPE_TRIGGER | 4 | | @@ -73,8 +73,8 @@ class NotificationType{ <> NOTIFICATION_TYPE_UNSPECIFIED NOTIFICATION_TYPE_DATA_COMPLETE - NOTIFICATION_TYPE_DATA_TIMEOUT_1 - NOTIFICATION_TYPE_DATA_TIMEOUT_2 + NOTIFICATION_TYPE_DATA_TIMEOUT_SHORT + NOTIFICATION_TYPE_DATA_TIMEOUT_MEDIUM NOTIFICATION_TYPE_TRIGGER } ``` From 9a59c4bd9f5e36b599933723ab8a49a1898da7bb Mon Sep 17 00:00:00 2001 From: Bot Date: Tue, 14 Nov 2023 09:48:28 +0000 Subject: [PATCH 3/4] Buf re-generated protos --- docs/task.proto.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/task.proto.md b/docs/task.proto.md index 6310e6a..4bb077f 100644 --- a/docs/task.proto.md +++ b/docs/task.proto.md @@ -36,13 +36,13 @@
The different type of notifications generated by the real time processing.
-| Name | Ordinal | Description | -|----------------------------------|---------|-------------| -| NOTIFICATION_TYPE_UNSPECIFIED | 0 | | -| NOTIFICATION_TYPE_DATA_COMPLETE | 1 | | -| NOTIFICATION_TYPE_DATA_TIMEOUT_SHORT | 2 | | +| Name | Ordinal | Description | +|---------------------------------------|---------|-------------| +| NOTIFICATION_TYPE_UNSPECIFIED | 0 | | +| NOTIFICATION_TYPE_DATA_COMPLETE | 1 | | +| NOTIFICATION_TYPE_DATA_TIMEOUT_SHORT | 2 | | | NOTIFICATION_TYPE_DATA_TIMEOUT_MEDIUM | 3 | | -| NOTIFICATION_TYPE_TRIGGER | 4 | | +| NOTIFICATION_TYPE_TRIGGER | 4 | | From 70a350c6042a083a5e49daf3276fca199da08a57 Mon Sep 17 00:00:00 2001 From: hiimjako Date: Tue, 14 Nov 2023 09:48:48 +0000 Subject: [PATCH 4/4] docs(release_notes): update RELEASE_NOTES.md --- RELEASE_NOTES.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index fda3d8e..bf58b44 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,6 @@ # ProtoBuf Release Notes -## 0.0.2-dev - 2023-11-13 +## 0.0.2-dev - 2023-11-14 ### Bug Fixes @@ -10,3 +10,7 @@ - Update documentation to reflect protocol buffer refactoring (PR #15 by @chicco785) + +### Refactoring + +- Update NotificationType names (PR #17 by @hiimjako)