Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #205 bug when patching a map via api/v2/ it always receives subtype tabular collection #206

Conversation

mwallschlaeger
Copy link

Description

ref GeoNodeUserGroup-DE#1

Type of Change

Please select the relevant option:

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • Other (please describe)

Related Issue

If there is an existing issue related to this pull request, please reference it here.

closes #205

Checklist

Please ensure that your pull request meets the following requirements:

  • The pull request is limited to one type (docs, feature, bug fix, etc.)
  • The pull request is as small as possible. Consider opening multiple pull requests instead of one large one.
  • The feature or bug fix has been discussed and documented in an issue beforehand.

Additional Notes

Any additional information or context regarding the pull request can be provided here.

Thank you for creating this pull request

ridoo and others added 4 commits October 1, 2024 08:51
…": "tabular-collection"`

An `all(...)` on an empty list returns `True` which causes maps (having no `map_layers`) being saved as tabular collection. In a multistep workflow with an empty map created first and adding map layers in a later step would result in a `tabular-collection` independend of the map layer's type.
@mwallschlaeger mwallschlaeger added the bug Something isn't working label Nov 22, 2024
@mwallschlaeger mwallschlaeger self-assigned this Nov 22, 2024
@mwallschlaeger mwallschlaeger merged commit 53d39a8 into main Nov 22, 2024
1 check passed
@mwallschlaeger mwallschlaeger deleted the issue_#205_Bug_When_patching_a_map_via_api/v2/_it_always_receives_subtype_tabular-collection branch November 22, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: When patching a map via api/v2/ it always receives "subtype": "tabular-collection
2 participants