New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronise zoom when applying filter #80

Open

lpatiny opened this issue Feb 6, 2024 · 1 comment

Contributor

lpatiny commented Feb 6, 2024

Before both zoom were synchronized and this was a nice functionality. Is it possible to get back the before/after filter zoom synchronization?

Contributor

stropitek commented Feb 6, 2024 •

edited

Loading

This is in principle feasible.

You can listen to zoom changes on one image, and update the zoom of the other images on each event. However I foresee some issues:

During the "pan" action, the zoom callback is called only when the action is finished (after releasing the mouse). So it would not really be a "live" sync.
Currently zoom callback is triggered both when interacting with the image (mouse wheel, click-drag-release on image) and when the zoom level is sent programmatically with setZoom. This will create an infinite loop.

I'm creating an issue in react-roi about this.

stropitek mentioned this issue

Controlled PanZoom component zakodium-oss/react-roi#119

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment