Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile breaks on Windows #64

Open
andrerpena opened this issue Sep 1, 2016 · 1 comment
Open

Makefile breaks on Windows #64

andrerpena opened this issue Sep 1, 2016 · 1 comment

Comments

@andrerpena
Copy link

Hi. First, thanks for this project. I have interest in it and I would eventually contribute.

My problem is that you're using MAKE which doesn't work on Windows (at least not on my installation). I have never used a Makefile before but from where I'm standing, you're just using it to perform operations Node.js people would do in a Node.js way 😄 And this is preventing me from compiling it.

Can I remove the Makefile file and create corresponding package.json scripts? I mean, would you accept a PR?

Thank you.

@zackyang000
Copy link
Owner

zackyang000 commented Sep 2, 2016

You are absolute correct. I choose Makefile to build this project because Makefile is easier maintain than npm script. Makefile has a little trouble running on windows, you have to install some tools for use MAKE command.

You can write it in package.json if you want, I will merge and appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants