Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more beat interval types #91

Open
mklein994 opened this issue Mar 2, 2023 · 0 comments
Open

Support more beat interval types #91

mklein994 opened this issue Mar 2, 2023 · 0 comments

Comments

@mklein994
Copy link

First off, thank you for writing this so clean. It was a joy to poke around and explore how everything worked. It took some effort to swap out the proprietary components for the free ones, but in the end, I got it.1

I managed to get it running locally, using my own Spotify API keys and so on (including swapping out FontAwesome for the free versions, so that it could compile). As I was tweaking the parameters around a bit, I discovered that when the music is less rhythmic (i.e. rubato), using the sections or segments beat intervals sometimes gave the visualization a bit more "life" (i.e. "awareness"). The beats and (to a lesser degree) tatums intervals don't quite fit when the song doesn't have a definite beat to begin with. Just a thought. Perhaps instead of toggling back and forth with b, it could cycle through them?

TL;DR:

-const beatInterval = setting('beatInterval', 'beats', types.enum(['beats', 'tatums']));
+const beatInterval = setting('beatInterval', 'beats', types.enum(['bars', 'beats', 'sections', 'segments', 'tatums']));

const beatInterval = setting('beatInterval', 'beats', types.enum(['beats', 'tatums']));
(amongst other changes)

Footnotes

  1. Speaking of which, what's the license for this project? I looked, but couldn't find one. It appears the @zach.winter/vue-common library is under MIT; would this possibly be using that as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant