You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Full stack trace is below. It looks like the recent change to add Windows support may have missed a universal_newlines=True parameter in the check_output call to get a git branch name.
I'm not sure why this wouldn't be caught on TravisCI. The tests fail for me locally with this error on both OS X and Linux, in Python 3.3.2 and 3.3.6.
$ coveralls --coveralls_url=https://10.228.98.37
Traceback (most recent call last):
File "/Users/jharrington/.pyenv/versions/rosie-hooks/bin/coveralls", line 11, in <module>
sys.exit(wear())
File "/Users/jharrington/.pyenv/versions/3.3.2/envs/rosie-hooks/lib/python3.3/site-packages/coveralls/__init__.py", line 95, in wear
parallel=args.parallel,
File "/Users/jharrington/.pyenv/versions/3.3.2/envs/rosie-hooks/lib/python3.3/site-packages/coveralls/api.py", line 7, in post
json_file = build_file(repo_token, service_job_id, service_name, git, source_files, parallel)
File "/Users/jharrington/.pyenv/versions/3.3.2/envs/rosie-hooks/lib/python3.3/site-packages/coveralls/api.py", line 22, in build_file
return StringIO(json.dumps(content))
File "/Users/jharrington/.pyenv/versions/3.3.2/lib/python3.3/json/__init__.py", line 236, in dumps
return _default_encoder.encode(obj)
File "/Users/jharrington/.pyenv/versions/3.3.2/lib/python3.3/json/encoder.py", line 191, in encode
chunks = self.iterencode(o, _one_shot=True)
File "/Users/jharrington/.pyenv/versions/3.3.2/lib/python3.3/json/encoder.py", line 249, in iterencode
return _iterencode(o, 0)
File "/Users/jharrington/.pyenv/versions/3.3.2/lib/python3.3/json/encoder.py", line 173, in default
raise TypeError(repr(o) + " is not JSON serializable")
TypeError: b'coveralls' is not JSON serializable
The text was updated successfully, but these errors were encountered:
Previous code in repository.py got the current git branch name by
doing a `check_output` call without the universal_newlines flag, so
it returned a byte string. Later when the request is made to
coveralls API with the branch name, the JSON encode fails with a
TypeError on the byte string.
I'm not sure why this isn't broken on TravisCI, but I'd guess it's
related to some language/encoding env vars.
Fixesz4r#56.
Full stack trace is below. It looks like the recent change to add Windows support may have missed a
universal_newlines=True
parameter in thecheck_output
call to get a git branch name.I'm not sure why this wouldn't be caught on TravisCI. The tests fail for me locally with this error on both OS X and Linux, in Python 3.3.2 and 3.3.6.
The text was updated successfully, but these errors were encountered: