-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move PR template to .github folder #144
Comments
@yvesgurcan PR template as in a HTML template or just a .md template? |
@GlobeFire Absolutely! There is a Markdown template for PRs here: https://github.com/yvesgurcan/web-midi-player/blob/master/PULL_REQUEST_TEMPLATE. Unfortunately, it looks like it is not possible or desirable to have multiple PR templates in GitHub. Therefore, I suggest that you simply move the existing template inside the |
Hello @yvesgurcan , I am a first-timer contributor and would love to solve this issue. But, I am a little confused as to what I should do here. Or has the issue already been solved? |
hey, @theOpetunde you are welcome to solve the issue. I am looking for a solution. If you find it feel free to make the PR. |
Hey @yvesgurcan, sure sounds good. Just to make it clear, you are suggesting that https://github.com/yvesgurcan/web-midi-player/blob/master/PULL_REQUEST_TEMPLATE |
Hey @GlobeFire and @theOpetunde, |
@yvesgurcan Thank you for the explanation |
@theOpetunde since this is your first time, you make a PR. |
Thank you @GlobeFire. You're very kind @yvesgurcan I have made a PR to solve the issue. Please check if I am correct and your feedback will be appreciated. |
Great job @theOpetunde! I've approved and merged your PR. @GlobeFire, there's plenty to do! If you want to keep working on good first issues, you can always look here: https://github.com/yvesgurcan/web-midi-player/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22. More specifically, you are more than welcome to open a PR for #47 or #38. If you're feeling more adventurous and want to write some code in React, there's also #12 . Let me know if you need help running the example on your machine. |
Thanks @yvesgurcan, I would love to work on the react issue. I'll try to run the example if required I will ping you. |
Problem
Describe the problem related to this feature request.
When non-functional updates are brought to the library, it's not relevant to have the checklist about making sure that the library builds, that tests pass, and so forth.
Solution
What solution do you suggest to solve this problem?
Create a simpler template asking the user to describe the changes in the PR without the checklist.
The text was updated successfully, but these errors were encountered: