Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL should be applied per line #2

Open
OriHoch opened this issue Jan 21, 2018 · 2 comments
Open

RTL should be applied per line #2

OriHoch opened this issue Jan 21, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@OriHoch
Copy link

OriHoch commented Jan 21, 2018

Reproduction

write text with mixed hebrew / english lines

testing mixed text
בדיקת טקסט מעורב
123 456
testing בדיקה
בדיקה testing

expected

  • line starting with hebrew letter should be RTL
  • line starting with non-alphabetic letters (e.g. numbers) should inherit the directional from previous line
  • all other lines should be LTR
testing mixed text
בדיקה טקסט מעורב
123 456
testing בדיקה
בדיקה testing

actual

all lines are RTL
image

@yuvalbl yuvalbl added the enhancement New feature or request label Jan 21, 2018
@yuvalbl yuvalbl self-assigned this Jan 21, 2018
@yuvalbl
Copy link
Owner

yuvalbl commented Jan 21, 2018

Not sure this behavior is a good idea.
It may cause a single paragraph to scatter all over.

I do intend to add an option section, which will let the user set custom behavior.
Suggestions in this regard are welcome

@yuvalbl
Copy link
Owner

yuvalbl commented Jan 21, 2018

@OriHoch
How about this options menu as custom-able behavior?
format is:
Element / type of text: < option 1 | option 2 | option 3> - bold option is default

Avatar and Name: < always left | according to first line | always right>
Contain RTL letter: < always right | right when first | always left>
LTR letters only: < always left | always right | inherit from previous line>
Non-alphabetic letters only: < always left | always right | inherit from previous line>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants