-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump kotlin from 1.9.21 to 1.9.22 #650
Conversation
Bumps `kotlin` from 1.9.21 to 1.9.22. Updates `plugin.serialization` from 1.9.21 to 1.9.22 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.9.21...v1.9.22) Updates `android` from 1.9.21 to 1.9.22 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.9.21...v1.9.22) --- updated-dependencies: - dependency-name: plugin.serialization dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: android dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
@@ -6,7 +6,7 @@ buildscript { | |||
plugins { | |||
jacoco | |||
id("com.diffplug.spotless") version "6.23.2" | |||
val kotlin = "1.9.21" | |||
val kotlin = "1.9.22" | |||
kotlin("plugin.serialization") version kotlin apply false | |||
kotlin("android") version kotlin apply false | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The provided code patch appears to be modifying a build script. Here are the observations and suggestions based on the given information:
-
Upgrade Kotlin version: The patch updates the Kotlin version from "1.9.21" to "1.9.22". This change could potentially include bug fixes and improvements, so updating the Kotlin version is generally recommended.
-
Unused plugin exclusions: The patch includes plugin exclusions for
kotlin("plugin.serialization")
andkotlin("android")
, withapply false
. These exclusions indicate that those plugins are not being applied in the current configuration. If these exclusions were intentional, such as not needing serialization or Android-related features, then there's no issue. Otherwise, review whether removing these exclusions is necessary. -
Missing context: It is difficult to provide an extensive code review without additional context. It would be helpful to know the purpose and structure of the buildscript, as well as any other relevant code dependencies or usage. Knowing the specific goals or requirements of the codebase would allow for a more thorough review.
Overall, the code patch seems straightforward and primarily focused on upgrading the Kotlin version. However, it is essential to consider the context and potential implications on other parts of the codebase before applying the changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #650 +/- ##
=============================================
- Coverage 69.18% 69.09% -0.09%
Complexity 574 574
=============================================
Files 76 76
Lines 4453 4453
Branches 537 537
=============================================
- Hits 3081 3077 -4
- Misses 1038 1041 +3
- Partials 334 335 +1 ☔ View full report in Codecov by Sentry. |
Bumps
kotlin
from 1.9.21 to 1.9.22.Updates
plugin.serialization
from 1.9.21 to 1.9.22Release notes
Sourced from plugin.serialization's releases.
Changelog
Sourced from plugin.serialization's changelog.
Commits
44ed2e9
Add changelog for 1.9.22b7b0397
[Gradle] Made klib unpacked for native metadata compile task262697d
[K/JS] Fix file extension inside the JS KGP to run tests with ES modules ^KT-...87c8aa1
[K/JS] Fix case with boxing/unboxing inside the BlockDecomposerLowering ^KT-6...316df8d
[CLI] Add cache for reflection lookup of CLI argumentsb0cc245
Avoid throwing exception when BuildFusService can't be injectedcfbb957
[IR] Correct handling of loops in liveness analysis204cecd
[box-tests] Added a reproducer for #KT-641399c7aac2
[gradle] Use more fine grained directory for K/N incremental compilation9012e67
Add KotlinBuilder 'dumb mode' flagUpdates
android
from 1.9.21 to 1.9.22Release notes
Sourced from android's releases.
Changelog
Sourced from android's changelog.
Commits
44ed2e9
Add changelog for 1.9.22b7b0397
[Gradle] Made klib unpacked for native metadata compile task262697d
[K/JS] Fix file extension inside the JS KGP to run tests with ES modules ^KT-...87c8aa1
[K/JS] Fix case with boxing/unboxing inside the BlockDecomposerLowering ^KT-6...316df8d
[CLI] Add cache for reflection lookup of CLI argumentsb0cc245
Avoid throwing exception when BuildFusService can't be injectedcfbb957
[IR] Correct handling of loops in liveness analysis204cecd
[box-tests] Added a reproducer for #KT-641399c7aac2
[gradle] Use more fine grained directory for K/N incremental compilation9012e67
Add KotlinBuilder 'dumb mode' flagYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)