-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump serializationVersion from 1.5.0 to 1.5.1 #567
Conversation
@@ -146,7 +146,7 @@ tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile>().configureEach | |||
|
|||
dependencies { | |||
val coroutinesVersion = "1.6.4" | |||
val serializationVersion = "1.5.0" | |||
val serializationVersion = "1.5.1" | |||
implementation("ch.acra:acra-mail:5.10.0-beta03") | |||
implementation("com.melnykov:floatingactionbutton:1.3.0") | |||
implementation("io.reactivex.rxjava2:rxjava:2.2.21") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code patch seems to be a minor update on dependency versions.
Here are some suggestions for improvement:
- Adding a comment explaining why a particular dependency is used would be helpful.
- It's recommended to use a lock file (e.g.
build.gradle.lock
), or its equivalent, along with the build file, which captures the exact version of dependencies. This can ensure consistency across builds and promote reproducibility.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #567 +/- ##
=============================================
- Coverage 70.13% 69.93% -0.21%
+ Complexity 570 569 -1
=============================================
Files 75 75
Lines 4340 4340
Branches 501 501
=============================================
- Hits 3044 3035 -9
- Misses 971 976 +5
- Partials 325 329 +4 ☔ View full report in Codecov by Sentry. |
@dependabot recreate |
7add675
to
0b869e7
Compare
@dependabot rebase and merge |
Looks like this PR is already up-to-date with develop! If you'd still like to recreate it from scratch, overwriting any edits, you can request |
Bumps `serializationVersion` from 1.5.0 to 1.5.1. Updates `org.jetbrains.kotlinx:kotlinx-serialization-protobuf` from 1.5.0 to 1.5.1 - [Release notes](https://github.com/Kotlin/kotlinx.serialization/releases) - [Changelog](https://github.com/Kotlin/kotlinx.serialization/blob/master/CHANGELOG.md) - [Commits](Kotlin/kotlinx.serialization@v1.5.0...v1.5.1) Updates `org.jetbrains.kotlinx:kotlinx-serialization-json` from 1.5.0 to 1.5.1 - [Release notes](https://github.com/Kotlin/kotlinx.serialization/releases) - [Changelog](https://github.com/Kotlin/kotlinx.serialization/blob/master/CHANGELOG.md) - [Commits](Kotlin/kotlinx.serialization@v1.5.0...v1.5.1) --- updated-dependencies: - dependency-name: org.jetbrains.kotlinx:kotlinx-serialization-protobuf dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jetbrains.kotlinx:kotlinx-serialization-json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
0b869e7
to
32e3042
Compare
@@ -146,7 +146,7 @@ tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile>().configureEach | |||
|
|||
dependencies { | |||
val coroutinesVersion = "1.7.1" | |||
val serializationVersion = "1.5.0" | |||
val serializationVersion = "1.5.1" | |||
implementation("ch.acra:acra-mail:5.10.0-beta03") | |||
implementation("com.melnykov:floatingactionbutton:1.3.0") | |||
implementation("io.reactivex.rxjava2:rxjava:2.2.21") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the provided code patch, there doesn't seem to be any bug risks. The changes appear to be safe and straightforward.
Regarding improvement suggestions, it's good practice to keep versions up-to-date to take advantage of the latest features and bug fixes. So upgrading the Coroutines and Serialization libraries to their latest versions might be a good idea. Additionally, it's generally recommended to avoid using "-beta" versions in production code and instead use stable releases.
Superseded by #609. |
Bumps
serializationVersion
from 1.5.0 to 1.5.1.Updates
org.jetbrains.kotlinx:kotlinx-serialization-protobuf
from 1.5.0 to 1.5.1Release notes
Sourced from org.jetbrains.kotlinx:kotlinx-serialization-protobuf's releases.
Changelog
Sourced from org.jetbrains.kotlinx:kotlinx-serialization-protobuf's changelog.
Commits
f833852
Prepare 1.5.1 release (#2297)a27e86f
Function to retrieve KSerializer by KClass and type arguments serializers (#2...5a8795a
Added FormatLanguage annotation to JSON (#2234)40eb277
Merge remote-tracking branch 'origin/master' into dev9157bf8
Implement addAll functions for JsonArrayBuilder (#2156)ef67bce
KeyValueSerializer: Fix missing call to endStructure() (#2272)8007574
ObjectSerializer: Respect sequential decoding (#2273)0a6eb81
Fix incorrect function name in PrimitiveSerialDescriptor doc comment (#2289)cfce5d8
Properties Format: Support sealed/polymorphic classes as class properties (#2...961e87d
Adapt tests for K2 and upcoming deprecations in K1 (#2230)Updates
org.jetbrains.kotlinx:kotlinx-serialization-json
from 1.5.0 to 1.5.1Release notes
Sourced from org.jetbrains.kotlinx:kotlinx-serialization-json's releases.
Changelog
Sourced from org.jetbrains.kotlinx:kotlinx-serialization-json's changelog.
Commits
f833852
Prepare 1.5.1 release (#2297)a27e86f
Function to retrieve KSerializer by KClass and type arguments serializers (#2...5a8795a
Added FormatLanguage annotation to JSON (#2234)40eb277
Merge remote-tracking branch 'origin/master' into dev9157bf8
Implement addAll functions for JsonArrayBuilder (#2156)ef67bce
KeyValueSerializer: Fix missing call to endStructure() (#2272)8007574
ObjectSerializer: Respect sequential decoding (#2273)0a6eb81
Fix incorrect function name in PrimitiveSerialDescriptor doc comment (#2289)cfce5d8
Properties Format: Support sealed/polymorphic classes as class properties (#2...961e87d
Adapt tests for K2 and upcoming deprecations in K1 (#2230)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)