Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it necessary to make the ios-build keychain the default keychain? #86

Open
starikcetin opened this issue Oct 13, 2022 · 2 comments
Open

Comments

@starikcetin
Copy link

starikcetin commented Oct 13, 2022

Hello,

After running this action on our self-hosted runners, we noticed the login keychain, which is the existing default, sometimes gets removed. According to fastlane/fastlane#17641 (comment), I suspect this line is the culprit:

default_keychain: true,

Is that line necessary? Can this action work without replacing the default keychain?

@brett-james-rocketlab
Copy link

The default action here makes normal usage of the OS painful as well - you will receive plenty of prompts about wanting to use the keychain - the keychain that you won't be able to unlock because it was created with a random string.

@aphillipo
Copy link

Okay, I have fixed this and I also make sure the ios-build.keychain is deleted before each creation: https://github.com/aphillipo/ios-build-action

Feel free to for my fork and reference it - probably not good to use this if you are running in a shared environment as I set the password to the empty string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants