Fallback NodeRenderer

[emad-elsaid]

• I had a situation where I want to render certain node in the AST if it has a specific property
• I would like to render the fenced code block in case the language matches a format such as alert or info.
• In case it doesn't match the format that I can handle I want to let the renderer continue rendering using the other lower priority node renderer.

I looked into the part that does the node rendering and noticed it returns an error and stops rendering?

goldmark/renderer/renderer.go

Line 168 in 60df4aa

return s, err

here are my thoughts so far:

• Maybe we can add another walk status WalkFallback and check if the node renderer returned it so we can continue to use the next renderer in the list
• Maybe we can have a predefined error that the renderer can use it to also tell us we should continue to render the node.

I'm interested in knowing:

• how do we feel about this problem? and if you faced it before
• is any of the proposed solutions/changes is viable?

[yuin]

I do not stand this idea.

Renderer should stick to rendering nodes. Renderer should not have logics like you suggested.
Have a think about case the following:
If anyone wants to render fenced code blocks whose language is alert as a pdf. He must write same logics as you written for HTML renderers.

So, in your case, it will be better that transform AST nodes as a specific node likeNoticeBlock. NoticeBlockRenderer will just render the nodes without logics.

[emad-elsaid]

Good point, I ended up actually doing this in my code here emad-elsaid/xlog@9f31a67

…

On Mon, Jan 2, 2023, 1:20 PM Yusuke Inuzuka ***@***.***> wrote: I do not stand this idea. Render should stick to rendering nodes. Renderer should not have logics like you suggested. Have a think about case the following: If anyone wants to render fenced code blocks whose language is alert as a pdf. He must write same logics as you written for HTML renderers. So, in your case, it will be better that transform AST nodes as a specific node likeNoticeBlock. NoticeBlockRenderer will just renderer the nodes without logics. — Reply to this email directly, view it on GitHub <#345 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAANJAYN5XFTR6WFZNWIOPTWQLBZJANCNFSM6AAAAAATNPGCJE> . You are receiving this because you authored the thread.Message ID: ***@***.***>