You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
It seems that 1.4.2 removed the
util.DedentPosition
func. As this is exposed publicly it could be considered a breaking change, and under semantic versioning would necessitate a major version bump. It has in fact broken goldmark-mathjax as it calls this method: https://github.com/litao91/goldmark-mathjax/blob/a43cf739a50fb884a05e49f65ea60a3fa9aa4203/block.go#L60It seems like there are three possible situations here:
In the case of 2 or 3 it would be good if this was documented somewhere (e.g. in the README) as it's a bit surprising to be broken by a patch release.
Beta Was this translation helpful? Give feedback.
All reactions