-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot crop on iOS 11 #215
Comments
For me work properly, can u give us an example please? |
Of course! For my product, Clique, we use it to crop images posted to the
app. Here is the process. Instead of cropping as a square, it uses the
entire photo from the camera roll.
The screenshots are attached. I hope this helps. Thank you so much for your
time!
…On Thu, Sep 28, 2017 at 4:20 AM FrankiDev_ ***@***.***> wrote:
For me work properly, can u give us an example please?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#215 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ANiFAm9yIr8fR4s2y3bPAsHJ7Euf_Ux7ks5sm1bkgaJpZM4PjqR6>
.
|
@j-down thanks for screenshot. Did you tried to set: cropHeightRatio = 1 // which means a squared-size photo |
Before it seemed to auto crop without setting that (I assume 1 is the default?). However, I just tried setting it to 1 manually and it still does not crop the image. |
Try with demo app, I'm not able to replicate the issue |
Just tried with demo app - same error. :/ are you testing this with iOS 11? |
Yes iOS 11, branch Swift-4 |
From my testings on iPhone 7 Plus running iOS 11: When selecting a vertical or horizontal screenshot, that has not been modified, fusuma does not crop the image. It returns the full horizontal or vertical screenshot. It appears @j-down had a similar issue when selecting screenshots specifically. It appears to me that the issue is when the width/height of the image is equivalent to the device width/height fusuma is not able to crop. Hence why it does not crop with screenshots. To test this theory: I took one of the horizontal screenshots from my device, and cropped a minute portion of the width. When I proceeded to crop in fusuma I got the desired image. I took one of the vertical screenshots from my device, and cropped a minute portion of the height. When I proceeded to crop in fusuma I got the desired image. I tested with an image of dimensions 5500 × 3637. I was able to crop without issue. I tested with a picture taken from the front facing cam. I was able to crop without issue. I tested with a picture taken from the rear facing cam. I was able to crop without issue. In summary the issue is only happening with device screenshots. |
Thanks for providing great library. Even I could not crop the images from gallery and photos in iOS 11. Is there any properties that need to be set to enable the crop in the library. |
The image cropping in the camera roll view does not work for iOS 11. Please fix as soon as possible, thank you for your time.
The text was updated successfully, but these errors were encountered: