Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rutschle.net download: missing v1.23.1 archive #433

Closed
yurtpage opened this issue Apr 9, 2024 · 4 comments
Closed

rutschle.net download: missing v1.23.1 archive #433

yurtpage opened this issue Apr 9, 2024 · 4 comments

Comments

@yurtpage
Copy link

yurtpage commented Apr 9, 2024

The last version present there is v1.23.0
The OpenWrt builds a package by a downloading sources from the site. We can change it to download from GitHub but generally official downloads are preferred.

@yrutschle
Copy link
Owner

v1.23.1 has been added to the Web site, thanks for reporting

@yurtpage
Copy link
Author

Thank you. It may be also useful to create a release from a tag here on GitHub
https://github.com/yrutschle/sslh/releases

Also please note that the OpenWrt is now going so switch to APK package manager from Alpine and this adds a restriction of version numbers:

APK uses a deterministic algorithm to compare versions and does not like random strings, except a valid hash prefixed with a ~.

openwrt/packages#23706

I'll send a PR with update of the sslh to the v1.23.1 which passes the restriction but in a future maybe the versions like v1.22c will be problematic

@yrutschle
Copy link
Owner

I have never used Github's releases, and it's not clear on first sight what they bring over tags... I'll look into it, but generally I prefer to keep adherence to Github minimal.

Github, on the other hand, pretty much forced me to move to semantic versioning (vX.Y.Z with each digit having a meaning in terms of API), which was a good thing: there will be no more v1.22c; I used to use the last letter as bug fixes, which corresponds to Z in semantic versionning, so v1.22c would be better written as v1.22.3. v.1.23.Z is the bugfix branch for v1, which will receive no further features.
So short answer is: don't worry, future versions should be compatible with OpenWRT requirements :-)

@yurtpage
Copy link
Author

yurtpage commented May 1, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants