Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify access logic for computed referenced projects via query access #53

Open
simonbaese opened this issue Jun 28, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@simonbaese
Copy link
Member

Access to project entities is determined in ProjectEntityAccess. For computed referenced projects the relation is determined via an entity query which does not respect the access control handler. At the moment, while computing referenced projects, all projects are queried with a subsequent access check - which requires loading the projects again (see ComputedProjectReferenceFieldItemList).

The access check should already happen during the query. The architecture of the project entity is already prepared and the event subscriber (provided by the entity module) can be found as ProjectQueryAccessSubscriber.

Building the queries might be very tricky though, because one has to respect the current status of the project and the role of the user in relation to the project. Also, there should be some mechanism to mirror the entity access check mentioned in the beginning.

@simonbaese simonbaese added the enhancement New feature or request label Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant