Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route context match is not validated for child entities #48

Open
simonbaese opened this issue Jun 17, 2022 · 0 comments
Open

Route context match is not validated for child entities #48

simonbaese opened this issue Jun 17, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@simonbaese
Copy link
Member

A child entity path looks something like this:
/grand-parent/{{grand-parent-id}}/parent/{{parent-id}}/child-entity/{{child-id}}

This way we can easily access related ("ancestor") entities when handling a child entity. See the some academy entities for example. A Course has Lectures which have Paragraphs which have Questions.

When accessing the route though we have the perspective of the child entity. Therefore the entity of {{child-id}} is loaded. Therefore, we could also access the child entity via some other path, e.g.:
/grand-parent/{{grand-parent-id}}/parent/{{some-other-parent-id}}/child-entity/{{child-id}}

There needs to be a validation for the route that the entities are actually related. That will help to build reliable bread crumbs for example.

@simonbaese simonbaese added the bug Something isn't working label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant