-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New example with autocomplete-light instead of select2 #1330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the example given, the forward argument in line 590: ```forward=(forward.Self())``` isn't a tuple. So I've updated the example to correct the error and also added a reminder that the forward argument expects a tuple.
Django2 introduced the SELECT2_TRANSLATIONS dictionary, and this was imported into the dal_select2.widgets module, causing an ImportError when run against any version of Django < 2. Fixes #1029
Django 2.1 has been released last week, so adding it to the build matrix
This makes select2 copy the CSS classes from original select element to the generated element.
…ms with their own jQuery. This was a major mind bender to figure out, but the detailed comments I've left should (hopefully) explain what's going on.
so that tox uses python version specified in travis.yml
Addresses #1058
…so be valid Python modules
Switches from using an unsupported private API (which changed and broke from django-querysetseqence>0.7) to a newly added public api method (`get_querysets`) which achieves the same thing. Depends on clokep/django-querysetsequence#53 Supersedes #1056 Fixes #1050
github-actions
bot
force-pushed
the
master
branch
from
May 22, 2023 10:33
cd06943
to
f0b3688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty simple example using the simple autocomplete-light.js web component which offers the following advantages over select2:
And the following drawbacks:
That said, we can start building on that, it's not bothering the select2 implementation code nor breaking compatibility AFAIK.