Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set minSdk to 21 #48

Merged
merged 1 commit into from
Jun 30, 2024
Merged

chore: set minSdk to 21 #48

merged 1 commit into from
Jun 30, 2024

Conversation

Artem13327
Copy link
Contributor

@Artem13327 Artem13327 commented May 27, 2024

In principle, I wanted to do something similar myself, but it turns out that not only me needs this.
Closes: #46

@Artem13327 Artem13327 marked this pull request as draft May 27, 2024 10:58
@Artem13327
Copy link
Contributor Author

The application works on Android 6
On Android 5 maybe I’ll check it a little later

@Artem13327 Artem13327 marked this pull request as ready for review May 27, 2024 11:21
@Artem13327
Copy link
Contributor Author

@DI555

@DI555
Copy link

DI555 commented May 27, 2024

@Artem13327 , on android 5.1 works fine and looks pretty cute!!!
Thank you so much!
I didn’t find options/settings button/menu and grey/black skin/theme tuning, but seems, i hope, it’ll be in a future!
Unpacket size is a little bit much, 120mb, but it may be cause of debug version.

So flying is good! Great thanks!

@Bnyro
Copy link
Member

Bnyro commented May 27, 2024

I'm pretty sure there's been a reasoning why @SuhasDissa set the minSDK to 24, and I honestly don't really think that we want to continue supporting that old SDKs as they're often a big source of issues and necessity of additional code to work around things that are not supported by old SDKs.

@SuhasDissa
Copy link
Member

There's no intentonal reason for choosing version 24. It was recommended by Android Studio when creating a new project, claiming that about 97% of devices run version 24 or newer.

@DI555
Copy link

DI555 commented May 27, 2024

@Bnyro , i can agree that sdk20 and olders are pretty old, but sdk21/22 not so old as you think, it’s a bigG policy to dropping it, with aim to buy "newest" ones..
sdk21/22 is still a very huge amount, so even if you drop it in LibreTube you’ll see a lack of previouse downloadings up for 1/3 or 1/4 part down((

so, i hope support it will be just only to compile builds with its numbers, other bugs not will have to be appeared!

@Bnyro
Copy link
Member

Bnyro commented May 27, 2024

Looking at https://www.composables.com/tools/distribution-chart, only less than 2.5% still use an SDK < 24 - and I'm pretty certain that most of these 2.5% just use their devices for phone calls and nothing else, so the target audience for SDK < 24 is probably not large enough to be reasonable to maintain in my opinion. But if Suhas is of a different opinion, merging that PR is okay with me.

@DI555
Copy link

DI555 commented May 27, 2024

@Bnyro , you forget just we’re not throwing away oldest ones, we’re giving it to granies and children)), so they are using its a lot!!!

@SuhasDissa
Copy link
Member

I don't think supporting v21 is that big of a problem for a calculator app, since it doesn't rely on any system API's. If supporting v21 is just as simple as changing one line of code, then there's no reason not to do it.

@Bnyro Bnyro changed the title minSdk = 21 chore: set minSdk to 21 Jun 30, 2024
@Bnyro Bnyro merged commit 04d3128 into you-apps:main Jun 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please, add to the CalcYou minSDK_21 (Android_5.0) !
4 participants