-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set minSdk to 21 #48
Conversation
The application works on Android 6 |
@Artem13327 , on android 5.1 works fine and looks pretty cute!!! So flying is good! Great thanks! |
I'm pretty sure there's been a reasoning why @SuhasDissa set the minSDK to 24, and I honestly don't really think that we want to continue supporting that old SDKs as they're often a big source of issues and necessity of additional code to work around things that are not supported by old SDKs. |
There's no intentonal reason for choosing version 24. It was recommended by Android Studio when creating a new project, claiming that about 97% of devices run version 24 or newer. |
@Bnyro , i can agree that sdk20 and olders are pretty old, but sdk21/22 not so old as you think, it’s a bigG policy to dropping it, with aim to buy "newest" ones.. so, i hope support it will be just only to compile builds with its numbers, other bugs not will have to be appeared! |
Looking at https://www.composables.com/tools/distribution-chart, only less than 2.5% still use an SDK < 24 - and I'm pretty certain that most of these 2.5% just use their devices for phone calls and nothing else, so the target audience for SDK < 24 is probably not large enough to be reasonable to maintain in my opinion. But if Suhas is of a different opinion, merging that PR is okay with me. |
@Bnyro , you forget just we’re not throwing away oldest ones, we’re giving it to granies and children)), so they are using its a lot!!! |
I don't think supporting v21 is that big of a problem for a calculator app, since it doesn't rely on any system API's. If supporting v21 is just as simple as changing one line of code, then there's no reason not to do it. |
In principle, I wanted to do something similar myself, but it turns out that not only me needs this.
Closes: #46