Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: new converter grid layout #13

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Conversation

M00NJ
Copy link
Member

@M00NJ M00NJ commented Dec 10, 2023

Some changes to the converter grid:

  • I used 3 instead of 2 items in a row, since they're still big enough to tap, but now there's no scrolling required anymore to reach the items at the bottom.
  • I used a different background color, since per guidelines there should only be one primary container per screen and because it was just to colorful imo.
  • I kept the primary color for the icons though, which make them stand out more now.
  • I renamed digital store to just storage to make the three items in a row layout possible. It also looks cleaner now, since it was the only string with two words. Also the old string name might cause problems with translation, like we've seen in ClockYou. I don't think there will be any confusion, since the icon makes it clear that it means digital storage.
Before After (dark) After (light)
signal-2023-12-10-143750_004 signal-2023-12-10-143750_003 signal-2023-12-10-143750_002

@M00NJ
Copy link
Member Author

M00NJ commented Dec 10, 2023

I you prefer this style as well I can change the color mapping in the character input tab to match it.

@SuhasDissa
Copy link
Member

Yea this style looks good

@M00NJ
Copy link
Member Author

M00NJ commented Dec 10, 2023

Can I merge these two PRs? We're good to go with the release then.

@SuhasDissa SuhasDissa merged commit 91ffddb into you-apps:main Dec 10, 2023
1 check passed
@M00NJ M00NJ deleted the converter-grid branch December 10, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants