From 17926ef456f1f296e3eeaacdb3762b0e509744d7 Mon Sep 17 00:00:00 2001 From: Youngteac Hong Date: Wed, 20 Nov 2024 21:59:36 +0900 Subject: [PATCH] Uncomment TODO in test --- packages/sdk/test/integration/gc_test.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/packages/sdk/test/integration/gc_test.ts b/packages/sdk/test/integration/gc_test.ts index 94469e2fd..f840d7c1b 100644 --- a/packages/sdk/test/integration/gc_test.ts +++ b/packages/sdk/test/integration/gc_test.ts @@ -1689,12 +1689,9 @@ describe('Garbage Collection', function () { assert.equal(doc2.getGarbageLen(), 2); assert.equal(doc2.getVersionVector().size(), 2); - // TODO(JOOHOJANG): remove below comments after https://github.com/yorkie-team/yorkie/issues/1058 resolved - // Due to https://github.com/yorkie-team/yorkie/issues/1058, removing deactivated client's version vector is not working properly now. - - //await client2.sync(); - //assert.equal(doc2.getGarbageLen(), 0); - //assert.equal(doc2.getVersionVector().size(), 1); + await client2.sync(); + assert.equal(doc2.getGarbageLen(), 0); + assert.equal(doc2.getVersionVector().size(), 1); }); it('attach > pushpull > detach lifecycle version vector test (run gc at last client detaches document, but no tombstone exsits)', async function ({