Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit command removes file attributes #11

Open
Jerrot opened this issue Jan 11, 2018 · 3 comments
Open

Edit command removes file attributes #11

Jerrot opened this issue Jan 11, 2018 · 3 comments

Comments

@Jerrot
Copy link

Jerrot commented Jan 11, 2018

After using beak edit and the final progress of copying the file back, the file attributes are lost. This is a little disturbing if you want to use the Shebang way to run your script, because you always need to execute the chmod again.

@yonaskolb
Copy link
Owner

You’re right. We could either fix that by copying the files back and forth instead of the writing from scratch that happens, or automatically set permissions on files with shebangs

@Jerrot
Copy link
Author

Jerrot commented Jan 11, 2018

Setting permissions automatically might be a source of unwanted security issues IMHO, people might be surprised to find their files executable on base of the content, if they decided to not set the flag yet before.

Copying sounds fine to me. I didn't dive deep enough into SwiftPM (and Beak) though to provide a patch/pr myself (yet) though.

@Jeehut
Copy link

Jeehut commented Feb 20, 2019

@yonaskolb Any plans on fixing this (or any other Beak issue) currently? This project looks like it's not being maintained anymore ... I'd be glad to help if you don't have the time. Just make me a maintainer and I'll try to update the project without any breaking changes as good as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants