Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling on Firefox mobile triggers popup despite settings #534

Closed
pavliuk-ii opened this issue Jan 16, 2024 · 4 comments
Closed

Scrolling on Firefox mobile triggers popup despite settings #534

pavliuk-ii opened this issue Jan 16, 2024 · 4 comments
Labels
browser/firefox The issue is Firefox-only kind/bug The issue or PR is regarding a bug

Comments

@pavliuk-ii
Copy link

pavliuk-ii commented Jan 16, 2024

Description
I've been using kiwi+yomichan until recently, so I decided to migrate to yomitan and on top of that switch to firefox.
There are two issues I currently have:

  1. If you set up scroll prevention inputs that used to work on old yomichan on yomitan, the popup stops showing up at all (configuration 1) (screenshot taken from https://github.com/KamWithK/AnkiconnectAndroid#instructions)
    I've tried changing settings a bit and found a configuration where it seems to work similarly (configuration 2), and it works well on kiwi, but here comes the second issue:
  2. When I use these settings on firefox, the popup still keeps appearing on scroll, despite "prevent touch scrolling" enabled. I suppose that it's the issue with how scrolling in firefox works, but is there any way to live with that? I can't read anything when once I scroll the screen a bit to advance with the text it throws a popup at me.

Browser version
Kiwi Browser 120 / Firefox Mobile 121.1.0

Yomitan version
23.12.29.0

Exported settings file
Two setting files, one for each input configuration:
input settings.zip

@pavliuk-ii pavliuk-ii added the kind/bug The issue or PR is regarding a bug label Jan 16, 2024
@djahandarie djahandarie added the browser/firefox The issue is Firefox-only label Jan 20, 2024
@djahandarie djahandarie changed the title Preventing popup on scroll issues (mobile) Scrolling on Firefox mobile triggers popup despite settings Jan 20, 2024
@djahandarie
Copy link
Collaborator

Hmm, haven't looked into it yet, but it must be that Firefox Mobile is triggering different events 🤔 I wonder why...

@Lyroxide
Copy link

@djahandarie This issue occurs on Kiwi browser too. With KamWithK's settings on Yomitan 23.12.29.0, a single tap press would not trigger a pop-up, but a long press will (with text selected incorrectly, but the pop-up is correct). Using Yomitan 23.11.23.0, this issue does not occur. Seems like a regression occurred somewhere.

@praschke
Copy link
Collaborator

praschke commented Mar 15, 2024

@pavliuk-ii "prevent touch scrolling" prevents cancelable touch move events from scrolling the view, it's not meant to prevent scanning.

i found a configuration using pointer inputs which improves over the emulated mouse in firefox android (on master).

  • tapping scans
  • scrolling doesn't scan, because scrolling results in a pointercancel instead of a pointerup
  • long taps produce a selection, and if you then scroll, you don't have to dismiss the popup to move the selection anchors
  • after interacting with the root popup (eg collapsible dictionaries, nested scanning), pointerup events on the underlying page don't target the root popup's document like emulated mousedown events do, so the root popup doesn't get stuck open or closed. i'm enabling "auto-hide search popup" just in case. [EDIT: this bug still prevents the underlying page from receiving clicks]
  • unfortunately, dragging horizontally on a popup can still scroll the underlying page behind it and kill all popups except the root
  • unfortunately, clicking internal links can still scan the initial text of the new search results

Screenshot_20240315-220500
Screenshot_20240315-220405
Screenshot_20240315-220433

@Kuuuube
Copy link
Member

Kuuuube commented Apr 15, 2024

Fixed in #791 with the new touchtap option.

@Kuuuube Kuuuube closed this as completed Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser/firefox The issue is Firefox-only kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

No branches or pull requests

5 participants