-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling on Firefox mobile triggers popup despite settings #534
Comments
Hmm, haven't looked into it yet, but it must be that Firefox Mobile is triggering different events 🤔 I wonder why... |
@djahandarie This issue occurs on Kiwi browser too. With KamWithK's settings on Yomitan 23.12.29.0, a single tap press would not trigger a pop-up, but a long press will (with text selected incorrectly, but the pop-up is correct). Using Yomitan 23.11.23.0, this issue does not occur. Seems like a regression occurred somewhere. |
@pavliuk-ii "prevent touch scrolling" prevents cancelable touch move events from scrolling the view, it's not meant to prevent scanning. i found a configuration using pointer inputs which improves over the emulated mouse in firefox android (on master).
|
Fixed in #791 with the new touchtap option. |
Description
I've been using kiwi+yomichan until recently, so I decided to migrate to yomitan and on top of that switch to firefox.
There are two issues I currently have:
I've tried changing settings a bit and found a configuration where it seems to work similarly (configuration 2), and it works well on kiwi, but here comes the second issue:
Browser version
Kiwi Browser 120 / Firefox Mobile 121.1.0
Yomitan version
23.12.29.0
Exported settings file
Two setting files, one for each input configuration:
input settings.zip
The text was updated successfully, but these errors were encountered: