From b97af39db9d4eb5369fac14ee5d0ecbeb0a0acab Mon Sep 17 00:00:00 2001 From: MarvNC Date: Thu, 26 Oct 2023 13:31:01 -0700 Subject: [PATCH 1/4] Autoformat --- README.md | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 1f25c0574e..a107fe5ed5 100644 --- a/README.md +++ b/README.md @@ -39,6 +39,8 @@ Yomitan provides advanced features not available in other browser-based dictiona - [Installation](#installation) - [Migrating from Yomichan](#migrating-from-yomichan) + - [Exporting Data](#exporting-data) + - [Custom Templates](#custom-templates) - [Dictionaries](#dictionaries) - [Basic Usage](#basic-usage) - [Importing Dictionaries](#importing-dictionaries) @@ -94,12 +96,12 @@ Due to security concerns, an alternate implementation of Handlebars is being use This revealed a bug in four of Yomitan's template helpers, which have now been fixed in the default templates. If your custom templates use the following helpers, please ensure their use matches the corrected forms. -Helper | Example | Corrected --------|---------|---------- -`formatGlossary` | `{{#formatGlossary ../dictionary}}{{{.}}}{{/formatGlossary}}` | `{{formatGlossary ../dictionary .}}` -`furigana` | `{{#furigana}}{{{definition}}}{{/furigana}}` | `{{furigana definition}}` -`furiganaPlain` | `{{~#furiganaPlain}}{{{.}}}{{/furiganaPlain~}}` | `{{~furiganaPlain .~}}` -`dumpObject` | `{{#dumpObject}}{{{.}}}{{/dumpObject}}` | `{{dumpObject .}}` +| Helper | Example | Corrected | +| ---------------- | ------------------------------------------------------------- | ------------------------------------ | +| `formatGlossary` | `{{#formatGlossary ../dictionary}}{{{.}}}{{/formatGlossary}}` | `{{formatGlossary ../dictionary .}}` | +| `furigana` | `{{#furigana}}{{{definition}}}{{/furigana}}` | `{{furigana definition}}` | +| `furiganaPlain` | `{{~#furiganaPlain}}{{{.}}}{{/furiganaPlain~}}` | `{{~furiganaPlain .~}}` | +| `dumpObject` | `{{#dumpObject}}{{{.}}}{{/dumpObject}}` | `{{dumpObject .}}` | Authors of custom templates may be interested to know that other helpers previously used and documented in the block form (e.g. `{{#set "key" "value"}}{{/set}}`), while not broken by this change, may also be replaced with the less verbose From 8e344180f64f656abf08a55ec145b8c750eae71e Mon Sep 17 00:00:00 2001 From: MarvNC Date: Thu, 26 Oct 2023 13:31:26 -0700 Subject: [PATCH 2/4] #227 Remove Kanjium --- README.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/README.md b/README.md index a107fe5ed5..8d7ce0109c 100644 --- a/README.md +++ b/README.md @@ -138,8 +138,6 @@ language is not English, you may consider also importing the English version for - [kanjidic_spanish.zip](https://github.com/themoeway/yomitan/raw/dictionaries/kanjidic_spanish.zip) - **[Innocent Corpus](https://web.archive.org/web/20190309073023/https://forum.koohii.com/thread-9459.html#pid168613)** (Term and kanji frequencies across 5000+ novels) - [innocent_corpus.zip](https://github.com/themoeway/yomitan/raw/dictionaries/innocent_corpus.zip) -- **[Kanjium](https://github.com/mifunetoshiro/kanjium)** (Pitch dictionary, see [related project page](https://github.com/toasted-nutbread/yomichan-pitch-accent-dictionary) for details) - - [kanjium_pitch_accents.zip](https://github.com/themoeway/yomitan/raw/dictionaries/kanjium_pitch_accents.zip) ## Basic Usage From 6824b323d07c9949c373508fbec6134b951c9fdb Mon Sep 17 00:00:00 2001 From: MarvNC Date: Thu, 26 Oct 2023 13:31:41 -0700 Subject: [PATCH 3/4] #195 Remove KireiCake --- README.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/README.md b/README.md index 8d7ce0109c..2bd4b709e8 100644 --- a/README.md +++ b/README.md @@ -129,8 +129,6 @@ language is not English, you may consider also importing the English version for - [jmdict_swedish.zip](https://github.com/themoeway/yomitan/raw/dictionaries/jmdict_swedish.zip) - **[JMnedict](https://www.edrdg.org/enamdict/enamdict_doc.html)** (Japanese names) - [jmnedict.zip](https://github.com/themoeway/yomitan/raw/dictionaries/jmnedict.zip) -- **KireiCake (upstream project dead)** (Japanese slang) - - [kireicake.zip](https://github.com/themoeway/yomitan/raw/dictionaries/kireicake.zip) - **[KANJIDIC](http://nihongo.monash.edu/kanjidic2/index.html)** (Japanese kanji) - [kanjidic_english.zip](https://github.com/themoeway/yomitan/raw/dictionaries/kanjidic_english.zip) - [kanjidic_french.zip](https://github.com/themoeway/yomitan/raw/dictionaries/kanjidic_french.zip) From 5e10b67c500b7af9d5af6d98caae9734ebdf984d Mon Sep 17 00:00:00 2001 From: MarvNC Date: Fri, 3 Nov 2023 11:44:08 -0700 Subject: [PATCH 4/4] Add Jitendex/JMdict dicts --- README.md | 25 +++++-------------------- 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/README.md b/README.md index 2bd4b709e8..7fe89b0922 100644 --- a/README.md +++ b/README.md @@ -114,28 +114,13 @@ different languages. You must download and import the dictionaries you wish to u definition lookups. If you have proprietary EPWING dictionaries that you would like to use, check the [Yomichan Import](https://foosoft.net/projects/yomichan-import) page to learn how to convert and import them into Yomitan. -Be aware that the non-English dictionaries contain fewer entries than their English counterparts. Even if your primary +Be aware that non-English dictionaries contain fewer entries than their English counterparts. Even if your primary language is not English, you may consider also importing the English version for better coverage. -- **[JMdict](https://www.edrdg.org/jmdict/edict_doc.html)** (Japanese vocabulary) - - [jmdict_dutch.zip](https://github.com/themoeway/yomitan/raw/dictionaries/jmdict_dutch.zip) - - [jmdict_english.zip](https://github.com/themoeway/yomitan/raw/dictionaries/jmdict_english.zip) - - [jmdict_french.zip](https://github.com/themoeway/yomitan/raw/dictionaries/jmdict_french.zip) - - [jmdict_german.zip](https://github.com/themoeway/yomitan/raw/dictionaries/jmdict_german.zip) - - [jmdict_hungarian.zip](https://github.com/themoeway/yomitan/raw/dictionaries/jmdict_hungarian.zip) - - [jmdict_russian.zip](https://github.com/themoeway/yomitan/raw/dictionaries/jmdict_russian.zip) - - [jmdict_slovenian.zip](https://github.com/themoeway/yomitan/raw/dictionaries/jmdict_slovenian.zip) - - [jmdict_spanish.zip](https://github.com/themoeway/yomitan/raw/dictionaries/jmdict_spanish.zip) - - [jmdict_swedish.zip](https://github.com/themoeway/yomitan/raw/dictionaries/jmdict_swedish.zip) -- **[JMnedict](https://www.edrdg.org/enamdict/enamdict_doc.html)** (Japanese names) - - [jmnedict.zip](https://github.com/themoeway/yomitan/raw/dictionaries/jmnedict.zip) -- **[KANJIDIC](http://nihongo.monash.edu/kanjidic2/index.html)** (Japanese kanji) - - [kanjidic_english.zip](https://github.com/themoeway/yomitan/raw/dictionaries/kanjidic_english.zip) - - [kanjidic_french.zip](https://github.com/themoeway/yomitan/raw/dictionaries/kanjidic_french.zip) - - [kanjidic_portuguese.zip](https://github.com/themoeway/yomitan/raw/dictionaries/kanjidic_portuguese.zip) - - [kanjidic_spanish.zip](https://github.com/themoeway/yomitan/raw/dictionaries/kanjidic_spanish.zip) -- **[Innocent Corpus](https://web.archive.org/web/20190309073023/https://forum.koohii.com/thread-9459.html#pid168613)** (Term and kanji frequencies across 5000+ novels) - - [innocent_corpus.zip](https://github.com/themoeway/yomitan/raw/dictionaries/innocent_corpus.zip) +- [Jitendex](https://github.com/stephenmk/Jitendex) - Jitendex is an improved version of JMdict for Yomitan. It features better formatting and some other improvements, and is actively being improved by its author. +- [JMdict](https://github.com/themoeway/jmdict-yomitan#jmdict-for-yomitan-1) - There are daily automatically updated builds of JMdict for Yomitan available in this repository. It is available in multiple languages and formats, but we recommend installing the more modern Jitendex for English users. +- [JMnedict](https://github.com/themoeway/jmdict-yomitan#jmnedict-for-yomitan) - JMnedict is a dictionary that lists readings of person/place/organization names and other proper nouns. +- [KANJIDIC](https://github.com/themoeway/jmdict-yomitan#kanjidic-for-yomitan) - KANJIDIC is an English dictionary listing readings, meanings, and other info about kanji characters. ## Basic Usage