Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INDENT rule: incorrectly works with multiline comments #349

Open
AlexCannonball opened this issue Sep 24, 2023 · 1 comment
Open

INDENT rule: incorrectly works with multiline comments #349

AlexCannonball opened this issue Sep 24, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@AlexCannonball
Copy link

Hello,

A text line like this " /*package package package*/ package pckg.v1;" gets the following error messages:

{
  filename: "file.proto",
  line: 4,
  column: 32,
  message: "Found an incorrect indentation style \"      \". \"\" is correct.", //six space chars as the incorrect indent
  rule: "INDENT",
}
{
  filename: "file.proto",
  line: 4,
  column: 3,
  message: "Found a possible incorrect indentation style. Inserting a new line is recommended.",
  rule: "INDENT",
}

So the first message tells that the indent is 6 space characters, taking two spaces from the second error and two spaces from the preceding multiline comment. I think the correct message for the first error is "Found an incorrect indentation style \" \". \"\" is correct."

Thank you.

@yoheimuta yoheimuta added the bug Something isn't working label Oct 1, 2023
@yoheimuta
Copy link
Owner

@AlexCannonball Sorry for the late response, and thank you for reaching out.
As you've pointed out, it's indeed a bug, and I'm addressing it when I have a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants